After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731303 - dataqueue: add bindings-friendly gst_data_queue_new_full()
dataqueue: add bindings-friendly gst_data_queue_new_full()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other Linux
: Normal trivial
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-06 00:05 UTC by Evan Nemerson
Modified: 2014-06-28 08:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Evan Nemerson 2014-06-06 00:05:19 UTC 
How about

GstDataQueue *
gst_data_queue_new_full (GstDataQueueCheckFullFunction checkfull,
                        gpointer checkfull_data,
                        GDestroyNotify checkfull_free,
                        GstDataQueueFullCallback fullcallback,
                        gpointer fullcallback_data,
                        GDestroyNotify fullcallback_free,
                        GstDataQueueEmptyCallback emptycallback,
                        gpointer emptycallback_data,
                        GDestroyNotify emptycallback_free) G_GNUC_MALLOC;
Comment 1 Tim-Philipp Müller 2014-06-07 08:35:16 UTC 
I don't know what the chances are that anyone will actually need this in practice... maybe we should just mark it as (skip) until someone asks for it.
Comment 2 Evan Nemerson 2014-06-10 15:32:13 UTC 
If you wait until someone asks then it will not be in available on their system for quite a while--probably not until then next stable release, which are painfully rare for some systems (RHEL, Ubuntu LTS, Debian Stable, etc.), and by then it may be too late for them to use it.  Also, people who need it may not bother reporting the issue--they may just move on.

The fix is pretty easy, and it's not a big maintenance burden, so I don't see much of a reason to hold off.
Comment 3 Sebastian Dröge (slomo) 2014-06-22 15:14:35 UTC 
This API is mostly useless for other languages. They have their own data structures.

We should just hide it from introspection.
Comment 4 Sebastian Dröge (slomo) 2014-06-26 17:33:07 UTC 
commit 4720e6d0e0327fe5e8cf83e03a00e57540b6c943
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Jun 26 19:31:33 2014 +0200

    dataqueue: Hide from bindings
    
    Other languages have their own data structures that are more convenient to
    use.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731303