After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731289 - New Game button is slightly wider than Clear Board button
New Game button is slightly wider than Clear Board button
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-05 19:46 UTC by Michael Catanzaro
Modified: 2014-06-10 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Group 'New Puzzle' and 'Clear Board' buttons in a SizeGroup (1.64 KB, patch)
2014-06-10 09:36 UTC, Parin Porecha
none Details | Review
Picture with problem (3.73 KB, image/png)
2014-06-10 09:58 UTC, Mario Wenzel
  Details
Group 'New Puzzle' and 'Clear Board' buttons in a SizeGroup (1.64 KB, patch)
2014-06-10 10:30 UTC, Parin Porecha
committed Details | Review

Description Michael Catanzaro 2014-06-05 19:46:37 UTC
The New Game button is subtly larger than Clear Board. We need to put the New Game button into a Gtk.SizeGroup with the Clear Board button in order to expand the Clear Board button to be the same width as New Game.
Comment 1 Parin Porecha 2014-06-10 09:36:22 UTC
Created attachment 278192 [details] [review]
Group 'New Puzzle' and 'Clear Board' buttons in a SizeGroup

I could not reproduce this bug on my machine (or maybe I didn't notice the subtlety), but here attached is a patch which adds both the buttons to a sizegroup.
Comment 2 Mario Wenzel 2014-06-10 09:58:56 UTC
Created attachment 278193 [details]
Picture with problem

This doesn't seem to fix the issue. There are still about three pixels missing (zoom in closer to the attached image).

I think that needs to be Horizontal mode.
Comment 3 Parin Porecha 2014-06-10 10:30:38 UTC
Created attachment 278198 [details] [review]
Group 'New Puzzle' and 'Clear Board' buttons in a SizeGroup

Ah, only if the bug title was a little more specific.
Updated title and patch.
Comment 4 Mario Wenzel 2014-06-10 11:26:55 UTC
Review of attachment 278198 [details] [review]:

Seems alright and also works. :)
Comment 5 Parin Porecha 2014-06-10 12:13:50 UTC
Comment on attachment 278198 [details] [review]
Group 'New Puzzle' and 'Clear Board' buttons in a SizeGroup

Pushed as 32a78a5