After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731150 - MSN live connection not removed from mission-control
MSN live connection not removed from mission-control
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
3.10.x
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-03 08:38 UTC by Laurent Bigonville
Modified: 2014-06-11 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
goa-mc-plugin: Remove Windows Live chat using Jabber (1.47 KB, patch)
2014-06-03 13:23 UTC, Debarshi Ray 		committed Details | Review

Description Laurent Bigonville 2014-06-03 08:38:43 UTC 
Hello,

Goa has removed MSN live chat support, but the mission-control connection is still present. The removal from the switch in g-c-c makes it impossible for the user to disable the account.

But the biggest problem IMHO is that goa is recreating the mission control account even if it gets deleted with the mc-tool command or in empathy-accounts
Comment 1 Debarshi Ray 2014-06-03 10:21:37 UTC 
Can you see this recreated account in Settings -> Online Accounts ?
Comment 2 Laurent Bigonville 2014-06-03 12:01:04 UTC 
The MSN account is still present in Settings -> Online Accounts. But there is only the Mail and document switches, not the one related to IM
Comment 3 Debarshi Ray 2014-06-03 13:23:09 UTC 
Created attachment 277796 [details] [review]
goa-mc-plugin: Remove Windows Live chat using Jabber
Comment 4 Debarshi Ray 2014-06-03 13:24:46 UTC 
... and reassigning to empathy.
Comment 5 Laurent Bigonville 2014-06-03 13:37:58 UTC 
Shouldn't goa also remove any existing MC connection on upgrade?
Comment 6 Debarshi Ray 2014-06-03 13:48:15 UTC 
(In reply to comment #5)
> Shouldn't goa also remove any existing MC connection on upgrade?

No, because GOA does not create any connections.
Comment 7 Laurent Bigonville 2014-06-03 14:34:52 UTC 
OK, tested the patch and it WORKSFORME


But now when restarting goa, I'm seeing an other problem. So I patched empathy, restarted goa (with the --replace flag) and goa is invalidating all the accounts. Restarting again and all the accounts are back in g-c-c. Apparently as soon as you have one disparity, all the accounts get invalidated by goa. I'll open a new bug for this I guess?
Comment 8 Guillaume Desmottes 2014-06-06 12:50:46 UTC 
Review of attachment 277796 [details] [review]:

++ please merge to master.
Comment 9 Laurent Bigonville 2014-06-09 08:46:10 UTC 
Regarding comment #7, I've open this new bug https://bugzilla.gnome.org/show_bug.cgi?id=731162
Comment 10 Guillaume Desmottes 2014-06-11 11:20:58 UTC 
Merged; will be in 3.12.3