After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731143 - waylandsink: Ensure that the frame sync callback has been completed after calling wl_display_dispatch()
waylandsink: Ensure that the frame sync callback has been completed after cal...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-03 06:14 UTC by Kazunori Kobayashi
Modified: 2014-06-17 12:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
waylandsink: Ensure that the frame sync callback has been completed after calling wl_display_dispatch() (1.20 KB, patch)
2014-06-03 06:14 UTC, Kazunori Kobayashi 		none Details | Review

Description Kazunori Kobayashi 2014-06-03 06:14:31 UTC 
Created attachment 277781 [details] [review]
waylandsink: Ensure that the frame sync callback has been completed after calling wl_display_dispatch()

Any events queued on the wl_display main queue are dispatched by
wl_display_dispatch(), but it is uncertain whether the frame sync callback
for the previous wl_surface_commit() has been completed after this function
call returns.
This patch makes sure to wait for the frame sync callback for every
frame.
Comment 1 Julien Isorce 2014-06-03 07:40:39 UTC 
Hi, thx for your patch though you should consider the waylandsink branches of http://cgit.collabora.com/git/user/gkiagia/gst-plugins-bad.git/
Comment 2 Damian Hobson-Garcia 2014-06-05 06:36:44 UTC 
(In reply to comment #1)
> Hi, thx for your patch though you should consider the waylandsink branches of
> http://cgit.collabora.com/git/user/gkiagia/gst-plugins-bad.git/

Hi. Is there　any plan to have the changes in this branch merged into the mainline gstreamer code? Or is that already underway to some extent?
Comment 3 George Kiagiadakis 2014-06-17 12:29:04 UTC 
Hi,

This branch was merged today, effectively rendering the patch in this bug report obsolete.

Thanks a lot for your effort into fixing this bug and submitting a patch for it. The patch is correct, but the code has been refactored in a way that it no longer makes any sense. We hope this event will not discourage you from submitting patches in the future.

George