Created attachment 278481 [details] [review]
Restore original behavior of "warn about unfillable squares"

Patch shows 'X' instead of None - http://i.imgur.com/Brb5hrj.png

Do we have any chance of reproducing that easily?

Created attachment 278556 [details]
Not working

Somehow, it doesn't work for me (there are a few unfillable squares) and also my color is borked.

This may be another issue with a non-dark theme.

(In reply to comment #3)
> Created an attachment (id=278556) [details]
> Not working
> 
> Somehow, it doesn't work for me (there are a few unfillable squares) and also
> my color is borked.
> 
> This may be another issue with a non-dark theme.

This isn't a problem with this patch.
Maybe in the detecting an unfillable square implentation, but since thats out of this bug's scope I'll try to reproduce it and file a bug.

and can you or Michael please review it ?

Thanks !

Without beeing able to reproduce the feature? What happens with different font and DPI settings? I can't test that for functionality. Using fonts sounds "dangerous" to me, that's why I wanted to test it beforehand.

Created attachment 279161 [details]
autosave file

Place in ~/.local/share/gnome-sudoku

Works for me.  Mario, are you sure you had this option enabled?  It's in the app menu.  If you're sure, please file a different bug.

Created attachment 279162 [details]
screenshot of new version

Created attachment 279163 [details]
screenshot of original version

Review of attachment 278481 [details] [review]:

I like this, but I think it would look better if the X was smaller, like in 3.12.

Created attachment 279321 [details] [review]
Restore original behavior of "warn about unfillable squares"

Patch updated.

Here's how the 'X' looks now - http://i.imgur.com/sSW2M6j.png

Review of attachment 279321 [details] [review]:

Yay!

Comment on attachment 279321 [details] [review]
Restore original behavior of "warn about unfillable squares"

Pushed as fa4db02