After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731116 - afp copy method does not report progress
afp copy method does not report progress
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afp backend
1.21.x
Other Linux
: Normal minor
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-02 17:04 UTC by Ross Lagerwall
Modified: 2014-06-04 06:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
afp: Report number of bytes copied (4.90 KB, patch)
2014-06-02 17:08 UTC, Ross Lagerwall 		committed Details | Review

Description Ross Lagerwall 2014-06-02 17:04:28 UTC 
g_file_copy is supposed to report progress, at least the number of bytes copied at the end. The afp server side copy method does not do this, which means when copying a bunch of files with Nautilus, the progress bar does not move.
Comment 1 Ross Lagerwall 2014-06-02 17:08:35 UTC 
Created attachment 277742 [details] [review]
afp: Report number of bytes copied

Report the number of bytes copied at the end since this is required by
the g_file_copy API.  This doesn't add any overhead either since we're
already stat()ing the source file.
Comment 2 Carl-Anton Ingmarsson 2014-06-02 17:41:26 UTC 
Review of attachment 277742 [details] [review]:

Looks great. Please commit.
Comment 3 Ross Lagerwall 2014-06-04 06:23:06 UTC 
Pushed to master as dd14287. Thanks for the quick review.