After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731031 - gnome-maps-3.12.2: path.js shouldn't be included in tarball
gnome-maps-3.12.2: path.js shouldn't be included in tarball
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-31 07:21 UTC by Pacho Ramos
Modified: 2014-06-11 12:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Makefile-js: Remove reduntant dependencies (1.28 KB, patch)
2014-06-03 17:40 UTC, Jonas Danielsson 		committed Details | Review
Makefile-js: Don't include generated files in dist (871 bytes, patch)
2014-06-03 17:40 UTC, Jonas Danielsson 		committed Details | Review

Description Pacho Ramos 2014-05-31 07:21:20 UTC 
It's autogenerated from src/path.js.in

Thanks
Comment 1 Jonas Danielsson 2014-06-03 17:40:41 UTC 
Created attachment 277819 [details] [review]
Makefile-js: Remove reduntant dependencies

config.js and path.js are included in $(js_files).
Comment 2 Jonas Danielsson 2014-06-03 17:40:44 UTC 
Created attachment 277820 [details] [review]
Makefile-js: Don't include generated files in dist

Make sure we filter out the built sources from the js files
list before adding it to EXTRA_DIST.
Comment 3 Zeeshan Ali 2014-06-03 19:19:30 UTC 
Review of attachment 277819 [details] [review]:

reduntant -> redundant

Seems right
Comment 4 Zeeshan Ali 2014-06-03 19:22:18 UTC 
Review of attachment 277820 [details] [review]:

::: src/Makefile-js.am
@@ +38,3 @@
 EXTRA_DIST +=								\
 	gnome-maps.js.gresource.xml					\
+	$(filter-out $(BUILT_SOURCES),$(subst ./,,$(js_files)))  	\

Don't know of this auto* magic so if it works[1], go ahead.

[1] Meaning you generated a tarball with this patch and then verified that:

* generated files are not in tarball
* tarball builds and runs fine