GNOME Bugzilla – Bug 731011
Sudoku Undo doesn't work, crashes
Last modified: 2014-05-31 13:44:08 UTC
Reported here: https://bugs.launchpad.net/ubuntu/+source/gnome-sudoku/+bug/1272716 https://errors.ubuntu.com/problem/401bb9a53ff62423e0ebb63049005074acf7aed5 (we're #24 in crashers!) Seems to be 3.10-git master (3.12) 1. Start a game 2. Put # in cell 3. Hit Undo
The crash reports are private? Traceback (most recent call last):
+ Trace 233651
self[index].inverse()
u.perform()
self.action(*self.action_args)
lambda *args: self.set(old_val),
self.set_value(value, tracker_id)
super(SudokuNumberBox, self).set_value(val)
if 0 < v <= self.upper:
I didn't think so.. but they do require a login.. hmm.. sorry! There's really not that much more info than the stracktace in there and where it occurs most.. (it's occurred most on Ubuntu 14.04 - 5457 times, whereas on 13.10 it only occurred 40 times.)
(In reply to comment #2) > (it's occurred most on Ubuntu 14.04 - 5457 times Oh dear
Created attachment 277599 [details] [review] check for none in set_value Been a while since I did python, but this seems to fix it...
I swear I tried that last night... oh well, yours works and doesn't seem to break anything. I pushed a slightly modified version. I'll do a new round of releases soonish to get this out, since it's hit so often. Ubuntu should just apply the patch manually; they're shipping a Frankensudoku halfway between 3.10 and 3.12. Attachment 277599 [details] pushed as 162ad9f - check for none in set_value
Seems to have been somehow introduced during the Python 3 port (I don't know enough Python to say how or why), so the fix is only needed in master, 3.12, and Ubuntu's heavily-patched 14.04 package.