After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730953 - Missing documentation (and annotations) for GstRTSPServer
Missing documentation (and annotations) for GstRTSPServer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
unspecified
Other Linux
: Normal normal
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 723910
 
 
Reported: 2014-05-29 18:39 UTC by Evan Nemerson
Modified: 2014-06-28 08:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
client: add missing documentation to signals (5.93 KB, patch)
2014-05-29 18:39 UTC, Evan Nemerson
committed Details | Review

Description Evan Nemerson 2014-05-29 18:39:24 UTC
Created attachment 277479 [details] [review]
client: add missing documentation to signals

Many of the signals in GstRTSPServer have parameters which aren't registered with GType, so G-I ends up with void* instead of the correct types.

The comment blocks I've added don't include a description of each signal—it would probably be wise to let someone familiar with the code handle that, and potentially write better descriptions for the parameters... all I really care about are the (type ...) annotations.
Comment 1 Wim Taymans 2014-06-24 07:52:20 UTC
I actually used a generic marshaller and the right GType for the context parameters. This is the remainder:

commit d08b46f4b7e778c5080ac90de6a7d381bcb0a83f
Author: Evan Nemerson <evan@nemerson.com>
Date:   Tue Jun 24 09:48:45 2014 +0200

    gi: improve annotations
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=730953