After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730902 - New HeaderBar doesn't support minimize button (add CSD to default build)
New HeaderBar doesn't support minimize button (add CSD to default build)
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: client
master
Other Linux
: High normal
: 0.12.0
Assigned To: Geary Maintainers
Geary Maintainers
: 730904 (view as bug list)
Depends on: 764812
Blocks:
 
 
Reported: 2014-05-28 19:18 UTC by Robert Schroll
Modified: 2016-05-21 03:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Robert Schroll 2014-05-28 19:18:13 UTC
I have my environment set up with a window button layout of ":minimize,close", which should give me a minimize and close button in the top right corner.  This is set both in dconf and in my GTK theme.  (Because obviously there should be two place where this is defined....)  In server-decorated windows, I get both buttons.  But with Geary's new client-decorated window, I get only a close button.

I'm not sure if this is a GTK issue or a Geary issue.  (I'm using GTK 3.10, if that matters.)  I'm posting it here for reference; please close it if it's actually GTK's fault (inconceivable!).
Comment 1 Jim Nelson 2014-05-28 19:56:30 UTC
This is a GTK issue with GtkHeaderBar.  In fact, by default it doesn't even have a close button, that's a property we set for the convenience of the user.

If you ./configure --enable-unity, it will build Geary in such a way that the GtkHeaderBar is more like a traditional toolbar and the client-side decorations (including the minimize button) is available.

I'm on the fence about GtkHeaderBar w/o the CSD and wanted to try it out (and hear from others) before making a decision.  I'll leave this open for now with a revised title.
Comment 2 Jim Nelson 2014-05-28 19:57:50 UTC
*** Bug 730904 has been marked as a duplicate of this bug. ***
Comment 3 Robert Schroll 2014-05-28 20:12:37 UTC
Yeah, I like the idea of the HeaderBar, but the implementation seems to be wanting in places.
Comment 4 Yosef Or Boczko 2014-05-28 20:16:57 UTC
I think this is a gtk+ issue.
Since GTK+ 3.12 you can to set the layout of the controls. I can to add
appmenu, close, maximize and mimimize (it works here).

I don't remember what was in GTK+ 3.10.

Another solution, is to add a setting if the headerbar needs to be custom title
of the window, or just as toolbar in the main box.
(we can to implement this, it just some of tricky :-)).
Comment 5 Michael Gratton 2016-05-21 03:16:13 UTC
Fixed by virtue of master now requiring 3.14, per bug 764812.