GNOME Bugzilla – Bug 730901
example: ts-parser: add linkage descriptor
Last modified: 2014-05-29 09:57:14 UTC
Created attachment 277407 [details] [review] bugfix missmage linkage parsing example: ts-parser: add linkage descriptor
Created attachment 277408 [details] [review] add linkage descriptor
Review of attachment 277408 [details] [review]: ::: tests/examples/mpegts/ts-parser.c @@ +79,3 @@ +static void +dump_memory_bytes (guint8 * data, guint len, guint spacing) Can you also refactor dump_memory_content() to call this (with desc->data + 2, desc->length - 2) ? @@ +451,3 @@ + } + if (res.private_data_length > 0) { + dump_memory_bytes (res.private_data_bytes, res.private_data_length, Just realized that these fields (and other fields of the linkagedescriptor) are being leaked because they don't have a free/reset function. I'm going to open a separate bug regarding this (common) issue
(In reply to comment #2) > Review of attachment 277408 [details] [review]: > > ::: tests/examples/mpegts/ts-parser.c > @@ +79,3 @@ > > +static void > +dump_memory_bytes (guint8 * data, guint len, guint spacing) > > Can you also refactor dump_memory_content() to call this (with desc->data + 2, > desc->length - 2) ? Don't work. we have a variable position, what we don't know.
(In reply to comment #3) > Don't work. we have a variable position, what we don't know. I don't understand what you mean. BTW, the bug regarding allocation/g-i : https://bugzilla.gnome.org/show_bug.cgi?id=730914
(In reply to comment #4) > (In reply to comment #3) > > Don't work. we have a variable position, what we don't know. > > I don't understand what you mean. > > BTW, the bug regarding allocation/g-i : > https://bugzilla.gnome.org/show_bug.cgi?id=730914 my fault, I have overseen the second part of your comment.
Created attachment 277439 [details] [review] add linkage descriptor
commit 74681cf00a3ab17d54963e7dbb8b2abaf259fd8e Author: Edward Hervey <bilboed@bilboed.com> Date: Thu May 29 11:55:51 2014 +0200 examples: factor dumping code We can just re-use the new function instead of having two duplicates commit 1db9d6c9dffeb47b4371e836a7cf559e67c17dd8 Author: Stefan Ringel <linuxtv@stefanringel.de> Date: Thu May 29 10:50:58 2014 +0200 example: ts-parser: add linkage descriptor https://bugzilla.gnome.org/show_bug.cgi?id=730901 commit f6fdd83b7ed47ae92d4857f0ca07edd136cce6dd Author: Stefan Ringel <linuxtv@stefanringel.de> Date: Wed May 28 20:42:05 2014 +0200 mpegts: bugfix mobile hand over linkage parse missmatch https://bugzilla.gnome.org/show_bug.cgi?id=730901