After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730897 - incoherent ucs2keysym prototype
incoherent ucs2keysym prototype
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-28 17:32 UTC by Samuel Thibault
Modified: 2014-06-07 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Samuel Thibault 2014-05-28 17:32:18 UTC
Hello,

As reported on http://bugs.debian.org/749597 ,

./registryd/ucs2keysym.c has

long ucs2keysym (long ucs)

while ./registryd/deviceeventcontroller-x11.c declares:

KeySym ucs2keysym (long ucs);

This brings an error with compilers which make link-time prototype coherency checks. On x86 platforms it happens that long or int would be returned through a register, whose truncation will be fine, but other archs will differ.

In the end, it would be way more preferable to put the declaration in a common ucs2keysym.h header file for instance.
Comment 1 Mike Gorse 2014-06-07 20:04:22 UTC
Hopefully I've just fixed this. Commit 7529a9 in master.