After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730893 - Dialogs use headerbars even when DialogsUseHeader is unset
Dialogs use headerbars even when DialogsUseHeader is unset
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-28 15:51 UTC by Lars Karlitski
Modified: 2014-10-18 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkdialog: don't use csd when use-header-bar is FALSE (4.17 KB, patch)
2014-05-28 15:51 UTC, Lars Karlitski 		none Details | Review
gtkaboutdialog: support showing buttons in action area (6.87 KB, patch)
2014-05-28 15:51 UTC, Lars Karlitski 		committed Details | Review
gtkdialog: don't use csd when use-header-bar is FALSE (6.02 KB, patch)
2014-06-12 08:49 UTC, Lars Karlitski 		needs-work Details | Review
Mark strings as translatable (1.81 KB, patch)
2014-10-16 19:48 UTC, Thomas Lange 		committed Details | Review

Description Lars Karlitski 2014-05-28 15:51:16 UTC 
Right now, dialogs always use header bars and the Gtk/DialogsUseHeader setting
only controls whether the buttons are in the action area or the header bar.

I'm unaware of a desktop environment that wants header bar with buttons in the
action area. The attached patches change this to use traditional title bars
when DialogsUseHeader is not set.
Comment 1 Lars Karlitski 2014-05-28 15:51:19 UTC 
Created attachment 277398 [details] [review]
gtkdialog: don't use csd when use-header-bar is FALSE
Comment 2 Lars Karlitski 2014-05-28 15:51:24 UTC 
Created attachment 277399 [details] [review]
gtkaboutdialog: support showing buttons in action area

Give GtkAboutDialog buttons in the action area instead of hard-coding
use-header-bar to TRUE. This is for environments which don't have the
Gtk/DialogsUseHeader xsetting turned on.
Comment 3 Matthias Clasen 2014-05-30 12:41:34 UTC 
The setting is documented as:

   * This setting does not affect custom dialogs using GtkDialog
   * directly, or message dialogs.
Comment 4 Lars Karlitski 2014-06-02 09:26:21 UTC 
(In reply to comment #3)
> The setting is documented as:
> 
>    * This setting does not affect custom dialogs using GtkDialog
>    * directly, or message dialogs.

How do the proposed patches break this?
Comment 5 Lars Karlitski 2014-06-12 08:49:37 UTC 
Created attachment 278320 [details] [review]
gtkdialog: don't use csd when use-header-bar is FALSE

Fix a11y test.
Comment 6 Matthias Clasen 2014-06-30 23:49:08 UTC 
Review of attachment 277399 [details] [review]:

this one is fine with me.
Comment 7 Matthias Clasen 2014-06-30 23:50:34 UTC 
Review of attachment 278320 [details] [review]:

This one doesn't apply anymore.
After manually applying it, I have one complaint: it breaks the nice rounded top of message dialogs, by giving them a server-side titlebar even under gnome-shell.
Comment 8 Matthias Clasen 2014-07-01 01:53:34 UTC 
Comment on attachment 277399 [details] [review]
gtkaboutdialog: support showing buttons in action area

Attachment 277399 [details] pushed as b6c4865 - gtkaboutdialog: support showing buttons in action area
Comment 9 Matthias Clasen 2014-07-01 01:54:17 UTC 
pushed with a fixup for message dialogs
Comment 10 Thomas Lange 2014-10-16 19:48:23 UTC 
Created attachment 288710 [details] [review]
Mark strings as translatable
Comment 11 Thomas Lange 2014-10-16 19:50:36 UTC 
The buttons shown in the GtkAboutDialog aren't translatable anymore
since this commit.
Attached is a patch which fixes this.

Please backport this also to 3.14. Thanks.
Comment 12 Matthias Clasen 2014-10-16 20:09:40 UTC 
Review of attachment 288710 [details] [review]:

yes
Comment 13 Thomas Lange 2014-10-17 06:55:46 UTC 
Could you commit the patch?
I don't have commit access.
Comment 14 Benjamin Otte (Company) 2014-10-18 20:57:37 UTC 
Comment on attachment 288710 [details] [review]
Mark strings as translatable

Committed the patch after being poked on IRC.