After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730872 - Please create an AppData file for Accerciser
Please create an AppData file for Accerciser
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Accerciser Developers
Accerciser Developers
Depends on:
Blocks:
 
 
Reported: 2014-05-28 09:18 UTC by Richard Hughes
Modified: 2015-01-21 17:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add AppData file (2.60 KB, patch)
2014-10-14 09:45 UTC, Daniel Mustieles 		needs-work Details | Review
Patch updated (2.78 KB, patch)
2014-10-23 10:54 UTC, Daniel Mustieles 		none Details | Review

Description Richard Hughes 2014-05-28 09:18:05 UTC 
Please consider writing and installing an AppData file with the application description and some screenshots, else Accerciser looks really bad in the GNOME and KDE Software Centers. We'd love to showcase more applications, but without the extra data file we can't. See http://people.freedesktop.org/~hughsient/appdata/ for details; thanks!

Richard
Comment 1 Daniel Mustieles 2014-10-14 09:45:16 UTC 
Created attachment 288498 [details] [review]
Add AppData file

Proposed patch to add the AppData file. Description has been taken from the wiki page. Feel free to change if you consider it's necessary.
Comment 2 Javier Hernández 2014-10-22 23:52:27 UTC 
Review of attachment 288498 [details] [review]:

Hey Dani,

thanks for your contribution!

Although the appdata file looks good to me, I don't like the idea of including this new file into the "src" folder.
My impression is that, given the absence of a "data" folder, this new file should be in the top-level folder of the repository like accerciser's .desktop or .gschema.xml files.
Comment 3 Daniel Mustieles 2014-10-23 10:54:33 UTC 
Created attachment 289197 [details] [review]
Patch updated

No problem Javier, here is the patch updated.

Thanks for your review!
Comment 4 Daniel Mustieles 2014-11-24 09:42:06 UTC 
Javi, it's ok to commit the new patch?

Thanks!
Comment 5 Javier Hernández 2015-01-21 17:02:46 UTC 
Review of attachment 289197 [details] [review]:

Hey Dani,

sorry for the long silence.
Just reviewed your patch and LGTM, thanks!


Could you please push it after rebasing it on top of master?

Cheers!
Comment 6 Daniel Mustieles 2015-01-21 17:34:18 UTC 
Done. Thanks!!