After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730858 - Font size diverges from default when the second tab is closed
Font size diverges from default when the second tab is closed
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-27 23:33 UTC by Egmont Koblinger
Modified: 2014-05-29 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (961 bytes, patch)
2014-05-28 14:32 UTC, Egmont Koblinger 		committed Details | Review

Description Egmont Koblinger 2014-05-27 23:33:46 UTC 
1. Start gnome-terminal.
2. Increase [or decrease] font size.
3. Open another tab, this new tab has the default font size.
4. Close the new tab.
5. (optional) goto 3 for even more fun :)

The font size of the first (and now only) tab becomes even bigger [or even smaller], as if the font size hotkey was pressed twice again.

git master only, 3.12 is unaffected.
Comment 1 Egmont Koblinger 2014-05-27 23:45:42 UTC 
The desired font size is restored on focus loss.
Comment 2 Egmont Koblinger 2014-05-27 23:53:53 UTC 
(reminds me to bug 685507)
Comment 3 Egmont Koblinger 2014-05-28 13:28:50 UTC 
The bug is caused by https://git.gnome.org/browse/gnome-terminal/commit/?id=dfd92cb
Comment 4 Egmont Koblinger 2014-05-28 14:32:37 UTC 
Created attachment 277391 [details] [review]
Fix
Comment 5 Christian Persch 2014-05-28 14:42:59 UTC 
Hmm. Looks fine to me.  Howver, I wonder if the VteTerminal not getting a style-updated signal when being added to the dragged-to window ?
Comment 6 Egmont Koblinger 2014-05-28 14:45:56 UTC 
Dunno.  The patch is not about style-updated at all.  It's about the scaled font description being fed back to the method that expects the unscaled description and applies the scale factor once again.
Comment 7 Egmont Koblinger 2014-05-28 14:56:00 UTC 
(In reply to comment #5)
> Hmm. Looks fine to me.  Howver, I wonder if the VteTerminal not getting a
> style-updated signal when being added to the dragged-to window ?

err... wait... didn't you mean to post this comment on bug 730850 instead?
Comment 8 Egmont Koblinger 2014-05-29 11:05:56 UTC 
Comment on attachment 277391 [details] [review]
Fix

5d934ec