After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730843 - Tweak extension prefs a bit
Tweak extension prefs a bit
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-27 17:25 UTC by Florian Müllner
Modified: 2014-05-28 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
alternate-tab: Tweak pref widget a bit (2.56 KB, patch)
2014-05-27 17:25 UTC, Florian Müllner 		committed Details | Review
workspace-indicator: Tweak prefs UI (3.01 KB, patch)
2014-05-27 17:25 UTC, Florian Müllner 		committed Details | Review
auto-move: Tweak prefs UI (6.61 KB, patch)
2014-05-27 17:25 UTC, Florian Müllner 		committed Details | Review
example: Tweak prefs UI (2.20 KB, patch)
2014-05-27 17:25 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-05-27 17:25:02 UTC 
Since we ship those in an official GNOME module, try to not make them look too terrible. Not sure about the example patch, however the others should at least improve what we have now.
Comment 1 Florian Müllner 2014-05-27 17:25:06 UTC 
Created attachment 277324 [details] [review]
alternate-tab: Tweak pref widget a bit

Adjust spacing to use more standard values and tweak alignments
to make the structure a bit more clear.
Comment 2 Florian Müllner 2014-05-27 17:25:12 UTC 
Created attachment 277325 [details] [review]
workspace-indicator: Tweak prefs UI

 - make tree view scrollable when list grows large
 - add some borders
 - use symbolic icons instead of (deprecated) stock items
 - adjust spacing/alignment
 - disable remove button when no item is selected
Comment 3 Florian Müllner 2014-05-27 17:25:18 UTC 
Created attachment 277326 [details] [review]
auto-move: Tweak prefs UI

- make tree view scrollable when list grows large
- add some borders
- use symbolic icons instead of (deprecated) stock items
- adjust spacing/alignment
- disable remove button when no item is selected
Comment 4 Florian Müllner 2014-05-27 17:25:23 UTC 
Created attachment 277327 [details] [review]
example: Tweak prefs UI

Position the explanatory text below the actual option and tweak
whitespace a bit.
Comment 5 Florian Müllner 2014-05-27 23:24:50 UTC 
Those tweaks should be fairly non-controversial, so pushing them.

Attachment 277324 [details] pushed as f4625f7 - alternate-tab: Tweak pref widget a bit
Attachment 277325 [details] pushed as de7fbe5 - workspace-indicator: Tweak prefs UI
Attachment 277326 [details] pushed as d0110cf - auto-move: Tweak prefs UI
Comment 6 drago01 2014-05-28 17:53:30 UTC 
Review of attachment 277327 [details] [review]:

Looks good also isn't really any more controversial then the others ;)
Comment 7 Florian Müllner 2014-05-28 20:46:10 UTC 
Attachment 277327 [details] pushed as 6a9c4e7 - example: Tweak prefs UI