After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730841 - grl-file-system: no notification changes for root container
grl-file-system: no notification changes for root container
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-27 16:59 UTC by Juan A. Suarez Romero
Modified: 2014-06-05 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adds file monitors to the base-uri chosen-uris paths. (1.18 KB, patch)
2014-05-31 03:22 UTC, Jeremy Whiting 		committed Details | Review

Description Juan A. Suarez Romero 2014-05-27 16:59:02 UTC 
When setting a different root container (like /home/user/Music) and we listen for changes, we get notifications for anything under any subfolder, but not for the Music folder itself).

So if we get a notification if we touch /home/user/Music/foo/bar.mp3 but not if we touch  /home/user/Music/bar.mp3  with base-uri set to /home/user/Music
Comment 1 Juan A. Suarez Romero 2014-05-27 17:03:26 UTC 
Reassigning bug (wrong component)
Comment 2 Jeremy Whiting 2014-05-27 20:19:17 UTC 
I don't see anywhere in grl-filesystem.c where add_monitor is called on the original chosen_uris list. It enumerates them and watches their subfolders, but I don't see any logic that calls add_monitor on the top level. Maybe simply adding that would fix this issue?
Comment 3 Juan A. Suarez Romero 2014-05-30 16:08:07 UTC 
Maybe we forgot to do it when we set up the base-uri.
Comment 4 Jeremy Whiting 2014-05-31 03:22:26 UTC 
Created attachment 277596 [details] [review]
Adds file monitors to the base-uri chosen-uris paths.

This patch seems to fix the issue here. Feel free to merge it if it looks good to you.
Comment 5 Juan A. Suarez Romero 2014-06-05 12:05:14 UTC 
Thanks!