GNOME Bugzilla – Bug 730793
"Saving..." appears multiple times when clicking on "Pause" often
Last modified: 2016-09-20 08:15:55 UTC
Created attachment 277261 [details] The bug When pausing a VM the Pause button should in every case instantly be disabled while the VM is paused/saved. Steps to reproduce: * Start a VM that takes a few seconds to pause * Click on pause several times * It should look similar to the appended screenshot * A bit of candy on top: an error that it is not possible to pause the VM (but its paused)
Commits that fixed this in chronological order: commit: ebb7ebe ebb7ebe68d46360428ac7df509985814ff1fd41e machine: Make 'can-save' a virtual property Instead of subclasses overriding the value of 'can-save' property, let them override the property getter itself so they can implement smarter (more dynamic) getters for it. commit: 5b3b6d5 5b3b6d588a647a331bf0dc4b7ffed59987259f3b libvirt-machine: Smarter 'can-save' implementation This property shoudl check the state of the machine rather than its user having to do that in addition to checking the value of this property. commit: 31e2883 31e28837b53ee7664b87fe10fef9a8168bc226b2 libvirt-machine: Add private 'saving' boolean field This field is set to true if machine is being saved currently. commit: 4a49633 4a496333edd48ef60d0c3c113ba4655cd7918f45 libvirt-machine: Not savable when being saved already Don't claim the machine to be savable if its being saved. This solves the issue of pause button still being available to user and Boxes leading into interesting scenerios if user clicks on the button.