After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730776 - Move dialog buttons into header bar
Move dialog buttons into header bar
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-26 18:27 UTC by Florian Müllner
Modified: 2014-05-27 00:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Update message-user dialog (6.36 KB, patch)
2014-05-26 18:27 UTC, Florian Müllner 		committed Details | Review
ui: Update connection-list dialog (3.23 KB, patch)
2014-05-26 18:27 UTC, Florian Müllner 		committed Details | Review
ui: Update join-dialog/connection-details-dialog (18.88 KB, patch)
2014-05-26 18:28 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-05-26 18:27:46 UTC 
This is a common GNOME 3 design pattern that we haven't adopted yet to keep consistency with GTK+'s built-in dialogs; those dialogs have been updated, so switch over our dialogs as well.
Comment 1 Florian Müllner 2014-05-26 18:27:50 UTC 
Created attachment 277238 [details] [review]
ui: Update message-user dialog

We didn't adapt the new dialog-buttons-in-header pattern due to
inconsistency with GTK+'s built-in dialogs; those have been
adjusted now, so let's go with it.
Comment 2 Florian Müllner 2014-05-26 18:27:58 UTC 
Created attachment 277239 [details] [review]
ui: Update connection-list dialog

Switch to using a header bar here as well ...
Comment 3 Florian Müllner 2014-05-26 18:28:03 UTC 
Created attachment 277240 [details] [review]
ui: Update join-dialog/connection-details-dialog

Update ConnectionDetails to not provide its own action buttons and
switch the remaining dialogs over to use buttons in the header.
Comment 4 Florian Müllner 2014-05-27 00:12:32 UTC 
Attachment 277238 [details] pushed as 710d8e6 - ui: Update message-user dialog
Attachment 277239 [details] pushed as e1a67ae - ui: Update connection-list dialog
Attachment 277240 [details] pushed as 96932bd - ui: Update join-dialog/connection-details-dialog