GNOME Bugzilla – Bug 730739
alt-esc (cycle-windows) no longer cycles through all windows in workspace
Last modified: 2017-01-05 16:50:57 UTC
I just upgraded from 3.8 to 3.12. In 3.8, alt-tab used to cycle through all the windows in the workspace, but that seems broken in 3.12. Right now alt-tab seems to only switch between the two last used windows in the workspace, ignoring all the others.
What's the output of: $ gsettings get org.gnome.desktop.wm.keybindings switch-applications $ gsettings get org.gnome.desktop.wm.keybindings switch-windows ?
emilio@titan:~$ gsettings get org.gnome.desktop.wm.keybindings switch-applications ['<Super>Tab'] emilio@titan:~$ gsettings get org.gnome.desktop.wm.keybindings switch-windows @as [] However, it is cycle-windows that I was using: emilio@titan:~$ gsettings get org.gnome.desktop.wm.keybindings cycle-windows ['<Alt>Escape'] That used to work fine, but no longer does. switch-windows could work as a workaround though.
Now I'm puzzled. You had cycle-windows set to <Alt>Tab and after updating it turned into <Alt>Escape ?
*Sigh*, I said alt-tab in my original description but I really meant alt-esc... sorry for the confusion. So it's alt-esc, i.e. cycle-windows, that isn't working well for me. alt-tab/super-tab is working well, but I don't use that.
Yeah, I removed the Alt-Escape code in mutter, forgetting we didn't have a switcher popup replacement for it in gnome-shell. I don't really want to add back the code there, as it was quite dusty. I'll see about adding back a replacement to gnome-shell.
(In reply to comment #5) > Yeah, I removed the Alt-Escape code in mutter, forgetting we didn't have a > switcher popup replacement for it in gnome-shell. I don't really want to add > back the code there, as it was quite dusty. I'll see about adding back a > replacement to gnome-shell. switch-windows could do as a replacement if doing: press alt press escape release escape press escape cycled through apps. Unfortunately hat doesn't work; you need the mouse pointer or the arrow keys to cycle through apps. But I just want to do alt-esc-esc-esc :-)
Created attachment 277197 [details] [review] switcherPopup: Add a return value to _keyPressHandler This allows us to handle keybindings that use Escape instead of just dismissing the popup unconditionally when we see an Escape press. -- That was a bug indeed.
Review of attachment 277197 [details] [review]: OK
Attachment 277197 [details] pushed as dd85670 - switcherPopup: Add a return value to _keyPressHandler
Reopening, as cycle-windows is still broken - the patch just fixed Escape in switch-windows/applications.
(In reply to comment #9) > Attachment 277197 [details] pushed as dd85670 - switcherPopup: Add a return value to > _keyPressHandler Nice. Can this go to gnome-3-12 as well please?
42619cd..0327bd0 gnome-3-12 -> gnome-3-12
*** Bug 753166 has been marked as a duplicate of this bug. ***
Hi, is there any progress on this?
*** Bug 762742 has been marked as a duplicate of this bug. ***
Created attachment 328188 [details] [review] altTab: Take over cycle-windows/cycle-group keybindings The code to handle cycling through windows without showing a popup was removed from mutter a while ago, which left the corresponding keybindings mostly broken (i.e. they now only switch between two windows). With the various switch-foo keybindings handled by the shell, it is now easier to take over the cycle-foo keybindings as well.
Hi Florian, I just tested your patch, and it's still switching only between the last two windows. It also has a slightly different behavior and now the window is only focused when you release the alt key insted of doing it instantly like before.
Created attachment 328189 [details] [review] altTab: Take over cycle-windows/cycle-group keybindings (In reply to Oscar Morante from comment #17) > I just tested your patch, and it's still switching only between the last two > windows. Using mutter/gnome-shell from master? Are there any warning? FWIW, it works as expected in my testing ... > It also has a slightly different behavior and now the window is only focused > when you release the alt key insted of doing it instantly like before. Yeah, I did that on purpose. The other switcher keybindings allow canceling the operation with Escape, so I didn't want to break that in case the binding itself doesn't involve Escape. Apparently that doesn't work without an actual popup though, so I updated the patch to switch windows immediately - that also fixes the ambiguity when switching between two unfocused windows that don't overlap ...
I've just tested it too on Fedora 24 and it cycles all the windows now. The window is focused after I release Tab key but it works for me.
The windows are focused immediately with the newer patch.
Created attachment 328205 [details] [review] windowManager: Avoid code duplication The various switcher keybindings are handled identically, except for the popup that is shown; update the code to reflect that instead of duplicating the code again and again. Optional cleanup on top of the last patch.
(In reply to Florian Müllner from comment #18) > Using mutter/gnome-shell from master? Are there any warning? FWIW, it works > as expected in my testing ... Oh, I tested on top of the last release, so that must be it. Thanks for fixing this :)
Review of attachment 328205 [details] [review]: looks good
Review of attachment 328189 [details] [review]: looks good, works fine, ship it
Attachment 328189 [details] pushed as bd6e7f1 - altTab: Take over cycle-windows/cycle-group keybindings Attachment 328205 [details] pushed as bf8d306 - windowManager: Avoid code duplication
*** Bug 668629 has been marked as a duplicate of this bug. ***