After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730729 - Please put back WINDOWPATH support
Please put back WINDOWPATH support
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.12.x
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-25 19:24 UTC by Samuel Thibault
Modified: 2014-07-22 21:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Revert "session: drop remnants of WINDOWPATH" (3.26 KB, patch)
2014-07-22 21:29 UTC, Ray Strode [halfline]
committed Details | Review
Revert "slave: Remove support for WINDOWPATH" (7.48 KB, patch)
2014-07-22 21:29 UTC, Ray Strode [halfline]
committed Details | Review

Description Samuel Thibault 2014-05-25 19:24:17 UTC
Hello,

For braille accessibility to work properly, the WINDOWPATH environment variable is indeed, to declare which VT the X session is running on. This was still supported in gdm 3.11.x, see the gdm_slave_set_windowpath function which fetches it from the XFree86_VT property.

I can see in the git log:

“
    slave: Remove support for WINDOWPATH
    
    It's an outdated, horrible system that doesn't really need to be
    in the code anymore. Die.
”

How the commiter knows that it is outdated and horrible, and even more, that is does not really need to be in the code??  This *is* needed for proper braille support.  Please at least ask people who have put the code in, before removing it...
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-05-25 19:32:38 UTC
XDG_VTNR should be used to retrieve the current VT.
Comment 2 Samuel Thibault 2014-05-25 19:42:50 UTC
So we now have to update *our* software, broken by the newer gdm version. Really, please notify people in advance about removing features they brought in.
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-05-25 19:46:10 UTC
Sorry, I didn't know that the feature was in use. When I talked to Ray about it, he said it was for a weird nested mode that we didn't use anymore. In any case, he may choose to revert it, so I left it open. I was just giving you the "supported" method for now.
Comment 4 Samuel Thibault 2014-07-22 21:06:34 UTC
Actually XDG_VTNR does not work when the user used startx from a text console: XDG_VTNR contains the VT of the text console where he ran startx, not the VT taken by the X server.
Comment 5 Ray Strode [halfline] 2014-07-22 21:09:59 UTC
does startx from the console set WINDOWPATH ?
Comment 6 Samuel Thibault 2014-07-22 21:12:16 UTC
Yes.
Comment 7 Samuel Thibault 2014-07-22 21:16:16 UTC
Btw, the WINDOWPATH rationale is on http://lists.x.org/archives/xorg/2005-December/011300.html and answers
Comment 8 Ray Strode [halfline] 2014-07-22 21:29:33 UTC
Created attachment 281439 [details] [review]
Revert "session: drop remnants of WINDOWPATH"

This reverts commit 6e1f486ca0d37da9fc8239493633deed6d796b93.
Comment 9 Ray Strode [halfline] 2014-07-22 21:29:37 UTC
Created attachment 281440 [details] [review]
Revert "slave: Remove support for WINDOWPATH"

This reverts commit 64210ac9dc1dafd1970ad0abcf46a010731d17b4.
Comment 10 Ray Strode [halfline] 2014-07-22 21:29:51 UTC
Attachment 281439 [details] pushed as e4dbf00 - Revert "session: drop remnants of WINDOWPATH"
Attachment 281440 [details] pushed as 13dc48d - Revert "slave: Remove support for WINDOWPATH"
Comment 11 Samuel Thibault 2014-07-22 21:39:56 UTC
thanks!