After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730653 - windowMenu: Only add workspace actions when enabled by session mode
windowMenu: Only add workspace actions when enabled by session mode
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-23 16:50 UTC by Florian Müllner
Modified: 2014-05-27 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
windowMenu: Only add workspace actions when enabled by session mode (1.28 KB, patch)
2014-05-23 16:50 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-05-23 16:50:28 UTC 
See patch.
Comment 1 Florian Müllner 2014-05-23 16:50:33 UTC 
Created attachment 277082 [details] [review]
windowMenu: Only add workspace actions when enabled by session mode

When workspaces are disabled by the session mode, all workspace
related actions don't make sense. Worse, the "Move to Workspace ..."
actions allow sending windows into a nirvana with no means to
get them back.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-05-23 17:41:38 UTC 
Review of attachment 277082 [details] [review]:

Interesting. I thought we would have locked the workspace count to 1 in hasWorkspaces = false.

I wonder if it makes sense to do that instead and hide "Always on Visible Workspace", etc. if there's only one workspace, but it's probably a weird enough edge case not to matter.

Let's just do this.
Comment 3 Florian Müllner 2014-05-27 17:53:21 UTC 
Attachment 277082 [details] pushed as 9f36611 - windowMenu: Only add workspace actions when enabled by session mode