After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730634 - androidmedia: discard defective codecs
androidmedia: discard defective codecs
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-23 12:42 UTC by Matthieu Bouron
Modified: 2018-05-06 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH 1/3] androidmedia: Skip the MP3Decoder found on the Sony Xperia Z (1.04 KB, patch)
2014-05-23 12:43 UTC, Matthieu Bouron 		none Details | Review
[PATCH 2/3] androidmedia: Add another not working codec to the blacklist (938 bytes, patch)
2014-05-23 12:43 UTC, Matthieu Bouron 		none Details | Review
[PATCH 3/3] androidmedia: Skip a defective codec found in Samsung Galaxy S3 (1.10 KB, patch)
2014-05-23 12:43 UTC, Matthieu Bouron 		none Details | Review

Description Matthieu Bouron 2014-05-23 12:42:15 UTC 
Patches backported from the gstreamer SDK.
Note that I didn't get the chance to test them since I don't have the related hardware.
Comment 1 Matthieu Bouron 2014-05-23 12:43:01 UTC 
Created attachment 277058 [details] [review]
[PATCH 1/3] androidmedia: Skip the MP3Decoder found on the Sony Xperia Z
Comment 2 Matthieu Bouron 2014-05-23 12:43:29 UTC 
Created attachment 277059 [details] [review]
[PATCH 2/3] androidmedia: Add another not working codec to the blacklist
Comment 3 Matthieu Bouron 2014-05-23 12:43:53 UTC 
Created attachment 277060 [details] [review]
[PATCH 3/3] androidmedia: Skip a defective codec found in Samsung Galaxy S3
Comment 4 Sebastian Dröge (slomo) 2014-05-23 12:46:26 UTC 
For the first one, I think I saw a working codec with that name on some device...
Comment 5 Sebastian Dröge (slomo) 2014-05-26 07:21:57 UTC 
Matthieu, what should we do about this one here? I think we need more information before merging these patches and especially some more guards as "MP3Decoder" is a rather generic name...
Comment 6 Sebastian Dröge (slomo) 2014-05-26 07:39:50 UTC 
Also did anybody report this to the device manifacturers?
Comment 7 Andoni Morales 2014-05-30 10:59:48 UTC 
We can warranty that these devices have buggy decoders, but we can't warranty that all the AACDecoder or MP3Decoder are buggy.

In our Fluendo branch we can blacklist them as we have AAC and MP3 decoders and but we don't have access to all the android devices in the market. We prefer using software decoders for audio when we find a buggy decoder in one device, rather than risking to have the same bug in more devices.

If decoders with the same name are known to work in other devices, the blacklist should be device specific, but how ?

It's more likely that the bugs are in the amcaudiodec implementation rather than in the device but it's hard to debug with a black box.
Comment 8 Vivia Nikolaidou 2018-05-06 10:39:57 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!