After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730597 - Use the new support for RTL icons in GtkIconTheme
Use the new support for RTL icons in GtkIconTheme
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-22 21:07 UTC by Yosef Or Boczko
Modified: 2014-05-23 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Bump required GTK+ version (737 bytes, patch)
2014-05-22 21:12 UTC, Yosef Or Boczko 		committed Details | Review
panels: Use the new support for RTL icons in GtkIconTheme (4.74 KB, patch)
2014-05-22 21:12 UTC, Yosef Or Boczko 		needs-work Details | Review
shell: Use the new support for RTL icons in GtkIconTheme (1.52 KB, patch)
2014-05-22 21:12 UTC, Yosef Or Boczko 		committed Details | Review
region: Use the new support for RTL icons in GtkIconTheme (1.73 KB, patch)
2014-05-23 09:37 UTC, Yosef Or Boczko 		committed Details | Review
user-accounts: Use the new support for RTL icons in GtkIconTheme (1.85 KB, patch)
2014-05-23 09:38 UTC, Yosef Or Boczko 		committed Details | Review
wacom: Use the new support for RTL icons in GtkIconTheme (1.82 KB, patch)
2014-05-23 09:38 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2014-05-22 21:07:22 UTC 
Depend on the last gtk+ from git master (3.13.0) for this.
Comment 1 Yosef Or Boczko 2014-05-22 21:12:00 UTC 
Created attachment 277009 [details] [review]
build: Bump required GTK+ version
Comment 2 Yosef Or Boczko 2014-05-22 21:12:13 UTC 
Created attachment 277010 [details] [review]
panels: Use the new support for RTL icons in GtkIconTheme
Comment 3 Yosef Or Boczko 2014-05-22 21:12:26 UTC 
Created attachment 277011 [details] [review]
shell: Use the new support for RTL icons in GtkIconTheme
Comment 4 Bastien Nocera 2014-05-23 07:22:23 UTC 
Review of attachment 277009 [details] [review]:

That looks fine.
Comment 5 Bastien Nocera 2014-05-23 07:23:24 UTC 
Review of attachment 277010 [details] [review]:

Given the number of panels affected, please split the commits up.
Comment 6 Bastien Nocera 2014-05-23 07:24:00 UTC 
Review of attachment 277011 [details] [review]:

Looks fine.
Comment 7 Yosef Or Boczko 2014-05-23 09:37:49 UTC 
Created attachment 277036 [details] [review]
region: Use the new support for RTL icons in GtkIconTheme
Comment 8 Yosef Or Boczko 2014-05-23 09:38:04 UTC 
Created attachment 277037 [details] [review]
user-accounts: Use the new support for RTL icons in GtkIconTheme
Comment 9 Yosef Or Boczko 2014-05-23 09:38:17 UTC 
Created attachment 277038 [details] [review]
wacom: Use the new support for RTL icons in GtkIconTheme
Comment 10 Bastien Nocera 2014-05-23 09:39:16 UTC 
Review of attachment 277036 [details] [review]:

Looks good
Comment 11 Bastien Nocera 2014-05-23 09:39:37 UTC 
Review of attachment 277037 [details] [review]:

Looks good
Comment 12 Bastien Nocera 2014-05-23 09:40:01 UTC 
Review of attachment 277038 [details] [review]:

Looks good as well.
Comment 13 Yosef Or Boczko 2014-05-23 09:42:14 UTC 
Review of attachment 277009 [details] [review]:

Pushed to master.
Comment 14 Yosef Or Boczko 2014-05-23 09:42:29 UTC 
Review of attachment 277011 [details] [review]:

Pushed to master.
Comment 15 Yosef Or Boczko 2014-05-23 09:42:40 UTC 
Review of attachment 277036 [details] [review]:

Pushed to master.
Comment 16 Yosef Or Boczko 2014-05-23 09:42:52 UTC 
Review of attachment 277037 [details] [review]:

Pushed to master.
Comment 17 Yosef Or Boczko 2014-05-23 09:43:05 UTC 
Review of attachment 277038 [details] [review]:

Pushed to master.