After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730596 - gst-python overrides broke due to a recent change in pygobject
gst-python overrides broke due to a recent change in pygobject
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
unspecified
Other Linux
: Normal normal
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 682886
 
 
Reported: 2014-05-22 20:50 UTC by Elad Alfassa
Modified: 2014-10-04 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (841 bytes, patch)
2014-05-22 20:53 UTC, Christoph Reiter (lazka)
committed Details | Review

Description Elad Alfassa 2014-05-22 20:50:43 UTC
Allow me to demonstrate this with code:

In [1]: from gi.repository import Gst

In [2]: Gst.init()
Out[2]: []

In [3]: Gst.Caps
Out[3]: gi.overrides.Gst.Caps

In [4]: Gst.Caps()
Out[4]: <GstCaps at 0x2b0ab70>

In [5]: Gst.Caps("hi")
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-5-d1c75c0c988e> in <module>()
----> 1 Gst.Caps("hi")

TypeError: function takes at most 0 arguments (1 given)

In [6]: Gst.Caps.__new__(None, "hi")
Out[6]: <GstCaps at 0x2b0ade0>


This is the offending commit https://git.gnome.org/browse/pygobject/commit/?id=3a2bfc8bf01fcae386355bc3652780e198e54d49

From IRC (#pitivi):
<lazka> you have to add __init__(self, *args, **kwargs): super(..).__init__()
<lazka> I didn't think  of other overrides (neither did simon it seems).. sorry :/


This issue prevents pitivi from being used in Fedora Rawhide.
Comment 1 Christoph Reiter (lazka) 2014-05-22 20:53:21 UTC
Created attachment 277006 [details] [review]
fix
Comment 2 Christoph Reiter (lazka) 2014-05-22 20:57:49 UTC
The patch is untested btw.