After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730578 - Make TpawAccountWidget work with dialogs using header bars
Make TpawAccountWidget work with dialogs using header bars
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: tp-aw
unspecified
Other All
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 729638
 
 
Reported: 2014-05-22 12:00 UTC by Debarshi Ray
Modified: 2014-06-04 11:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
account-widget: Make it work with dialogs using header bars (8.68 KB, patch)
2014-05-22 14:46 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-05-22 12:00:14 UTC 
Currently tpaw_account_widget_new_for_protocol expects an action area and the rest of the code is modelled around packing buttons into it. Dialogs using header bars don't use the action area for the buttons so this doesn't work.
Comment 1 Debarshi Ray 2014-05-22 14:46:50 UTC 
Created attachment 276993 [details] [review]
account-widget: Make it work with dialogs using header bars
Comment 2 Guillaume Desmottes 2014-05-23 07:38:52 UTC 
Review of attachment 276993 [details] [review]:

++ assuming you did check it was still working with empathy-accounts.
Comment 3 Debarshi Ray 2014-06-04 11:08:53 UTC 
(In reply to comment #2)
> Review of attachment 276993 [details] [review]:
> 
> ++ assuming you did check it was still working with empathy-accounts.

Yes, it works with empathy-accounts as far as I can tell.
Comment 4 Debarshi Ray 2014-06-04 11:09:12 UTC 
Comment on attachment 276993 [details] [review]
account-widget: Make it work with dialogs using header bars

Thanks for the review, cassidy!