After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730577 - Do not compress touch events so eagerly
Do not compress touch events so eagerly
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterStage
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-22 11:44 UTC by Carlos Garnacho
Modified: 2014-05-22 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
stage: Only compress consecutive touch events from the same sequence (1.30 KB, patch)
2014-05-22 11:45 UTC, Carlos Garnacho
committed Details | Review

Description Carlos Garnacho 2014-05-22 11:44:07 UTC
If motion event compression happens on the stage, the code also tries to compress touch events, although the check is too broad, and unfortunately eats events from the sequences, only sending a single event for the last updated sequence.

I'm attaching a patch that makes this only compress consecutive touch events from a same sequence, so all sequences are guaranteed to be emitted. This could be admittedly smarter and ensure only the last touch update is emitted for every sequence, but that'd involve peeking farther than the next event...
Comment 1 Carlos Garnacho 2014-05-22 11:45:02 UTC
Created attachment 276982 [details] [review]
stage: Only compress consecutive touch events from the same sequence

And get CLUTTER_EVENT_LEAVE out of the touch event compression logic, as
touches are always implicitly grabbed. If no sequence check is done, only
the last touch update would be emitted, even if multiple sequences got
updated.
Comment 2 Emmanuele Bassi (:ebassi) 2014-05-22 12:03:49 UTC
Review of attachment 276982 [details] [review]:

looks good. please, push to the clutter-1.20 and clutter-1.18 branches.
Comment 3 Carlos Garnacho 2014-05-22 12:57:59 UTC
Attachment 276982 [details] pushed as ed538a6 - stage: Only compress consecutive touch events from the same sequence