After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730543 - spice-gtk depends on spice-protocol
spice-gtk depends on spice-protocol
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2014-05-21 20:19 UTC by Michael Catanzaro
Modified: 2014-06-03 13:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
apps-3.14: add back spice-protocol (1.17 KB, patch)
2014-06-03 13:42 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2014-05-21 20:19:08 UTC
Trying to build Boxes:

configure: error: Package requirements (
  glib-2.0 >= 2.38.0
  gobject-introspection-1.0 >= 0.9.6
  gtk+-3.0 >= 3.11
  gtk-vnc-2.0 >= 0.4.4
  libvirt-gobject-1.0 >= 0.1.5
  libvirt-gconfig-1.0 >= 0.1.7
  libxml-2.0 >= 2.7.8
  spice-client-gtk-3.0 >= 0.15
  gudev-1.0 >= 165
  libosinfo-1.0 >= 0.2.9
  uuid >= 1.41.3
  libsoup-2.4 >= 2.38
) were not met:

Package 'spice-protocol', required by 'spice-client-glib-2.0', not found

Is spice-protocol something that would normally be added as a new module in gnome-apps?
Comment 1 Michael Catanzaro 2014-06-02 17:19:08 UTC
spice-protocol is a *part* of spice-gtk, as spice-common is a submodule of spice-gtk, and spice-protocol is a submodule of spice-common.  But spice-protocol is never built as part of spice-common, it is merely distributed with it: http://cgit.freedesktop.org/spice/spice-common/tree/Makefile.am

I'm confused as to how this is supposed to work. Are we intended to build spice-protocol separately?  If so, why is it a submodule of spice-common? Christophe, can you advise us?
Comment 2 Christophe Fergeau 2014-06-03 10:30:21 UTC
Yep this is a bit messy. spice-protocol should not be a submodule of spice-common. In the mean time, better to add the spice-protocol tarball. I'msurprised this only shows up now though, this used to work fine? Or was it just luck with people already having spice-protocol installed on their machines?
Comment 3 Michael Catanzaro 2014-06-03 12:25:04 UTC
I think it's been broken since February: https://git.gnome.org/browse/jhbuild/commit/modulesets?id=d4446a8697b74c9f5b3a11d73ded3e22d584d57c
Comment 4 Christophe Fergeau 2014-06-03 12:44:04 UTC
Ah indeed, the part of this commit removing spice-protocol should be reverted.
Comment 5 Michael Catanzaro 2014-06-03 13:42:36 UTC
The following fix has been pushed:
ecadd37 apps-3.14: add back spice-protocol
Comment 6 Michael Catanzaro 2014-06-03 13:42:40 UTC
Created attachment 277797 [details] [review]
apps-3.14: add back spice-protocol
Comment 7 Christophe Fergeau 2014-06-03 13:52:29 UTC
Looks good, thanks!