After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730536 - Add apis needed for mutters compositor bypass
Add apis needed for mutters compositor bypass
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: EGL
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-21 18:29 UTC by drago01
Modified: 2014-06-30 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
kms_winsys: Add cogl_kms_renderer_get_gbm api (1.61 KB, patch)
2014-05-21 18:30 UTC, drago01
committed Details | Review
kms-winsys: Add api that tells cogl to ignore a crtc (3.10 KB, patch)
2014-05-21 18:30 UTC, drago01
committed Details | Review

Description drago01 2014-05-21 18:29:38 UTC
To implement a compositor bypass feature in mutter we need two apis 

1) We need the underlying gbm device to be able to use gbm_bo_import
2) We need a way to tell cogl to stop messing with one or more outputs (because we scan out the apps buffer in that case).

The attached patches implement 1 and 2
Comment 1 drago01 2014-05-21 18:30:22 UTC
Created attachment 276944 [details] [review]
kms_winsys: Add cogl_kms_renderer_get_gbm api

Applications might want to get the underlying gbm device so add a getter for it.
Comment 2 drago01 2014-05-21 18:30:40 UTC
Created attachment 276945 [details] [review]
kms-winsys: Add api that tells cogl to ignore a crtc

An application might for whatever reason want to control a specific output
directly and have cogl only swap the other outputs if any. So add an api that
allows setting a crtc to be ignored.
Comment 3 Robert Bragg 2014-06-13 18:38:19 UTC
Really sorry for the long delay in following up on this; I haven't really had much time to spend looking at cogl 1.x issues.

These both look like simple and pragmatic things to help mutter, so I'm happy if you want to land them both if you're happy that they work for you.

I'm generally nervous of the idea of having multiple things trying to program the display hardware; that sounds like a recipe for pain at some point, but the current display api in cogl is lacking, so I'm happy with whatever you find works for you.

Reviewed-by: Robert Bragg <robert@sixbynine.org>
Comment 4 drago01 2014-06-30 18:25:17 UTC
Attachment 276944 [details] pushed as 4835187 - kms_winsys: Add cogl_kms_renderer_get_gbm api
Attachment 276945 [details] pushed as 93bcd0d - kms-winsys: Add api that tells cogl to ignore a crtc