GNOME Bugzilla – Bug 730509
facedetect: fix update on change
Last modified: 2014-07-22 11:17:07 UTC
Created attachment 276928 [details] [review] fix update on_change updates on_change post face detected for every frame, it should post bus messages only on_change
Enum "GstFaceDetectUpdates" Default: 0, "every_frame" (0): every_frame - Send update messages on every frame (1): on_change - Send update messages on change (face detected/not detected) (2): on_face - Send update messages when a face is detected (3): none - Send no messages update What if the face was detected changed position or if the number of detected faces change? I guess this "on_change" needs a better definition.
on_change means that a bus message is sended when a face is detected and another bus message is sended when no face is detected, no check is done on position or on number of faces, the description should be clear enough (face detected/not detected) however english is not my native languange, what do you suggest?
from reading comment #2, I have difficulties to understand the difference of (1) and (2).
on_change: - face detected => bus message - face detected => no bus message - face detected => no bus message - no face detected => bus message - no face detected => no bus message - no face detected => no bus message - face detected => bus message on_face: - face detected => bus message - face detected => bus message - face detected => bus message - no face detected => no bus message - no face detected => no bus message - face detected => bus message is clear now?
(In reply to comment #4) > on_change: > > - face detected => bus message > - face detected => no bus message > - face detected => no bus message > - no face detected => bus message > - no face detected => no bus message > - no face detected => no bus message > - face detected => bus message > > on_face: > > - face detected => bus message > - face detected => bus message > - face detected => bus message > - no face detected => no bus message > - no face detected => no bus message > - face detected => bus message > > is clear now? Yes, maybe it can be reworded: (1): on_change - Send messages when a new face is detected or one is not anymore detected (2): on_face - Send messages whenever a face is detected
Review of attachment 276928 [details] [review]: I think this makes sense.
Created attachment 281334 [details] [review] suggested descriptions
Review of attachment 281334 [details] [review]: make sense
Thanks for the review and updates, pushed both patches. commit bd4ae189388386baa34bdcd1dfe6f49c8d568649 Author: Nicola Murino <nicola.murino@gmail.com> Date: Mon Jul 21 21:03:26 2014 +0200 facedetect: improve enum GstFaceDetectUpdates descriptions https://bugzilla.gnome.org/show_bug.cgi?id=730509 commit 3896dd8413b22694409561920fd1b4bce095f514 Author: Nicola Murino <nicola.murino@gmail.com> Date: Wed May 21 12:59:57 2014 +0200 facedetect: make updates on_change works as expected https://bugzilla.gnome.org/show_bug.cgi?id=730509
thanks! can you please push to 1.4 branch too? No regression is possible
Done. commit 5e258dcc0fa4317c00e4e19ebf06d553bd5a6115 Author: Nicola Murino <nicola.murino@gmail.com> Date: Mon Jul 21 21:03:26 2014 +0200 facedetect: improve enum GstFaceDetectUpdates descriptions https://bugzilla.gnome.org/show_bug.cgi?id=730509 commit 028fce5bcd48ef267c4462b1973a381ea0a999e1 Author: Nicola Murino <nicola.murino@gmail.com> Date: Wed May 21 12:59:57 2014 +0200 facedetect: make updates on_change works as expected https://bugzilla.gnome.org/show_bug.cgi?id=730509
thanks