After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730476 - v4l2videodec: stalls on large seeks
v4l2videodec: stalls on large seeks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 727611
Blocks:
 
 
Reported: 2014-05-20 23:04 UTC by Dan Nicholson
Modified: 2014-05-26 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GST_DEBUG="3,v4l2*:7" totem (147.14 KB, application/x-gzip)
2014-05-20 23:04 UTC, Dan Nicholson 		Details

Description Dan Nicholson 2014-05-20 23:04:56 UTC 
Created attachment 276909 [details]
GST_DEBUG="3,v4l2*:7" totem

Using good commit 7df99f74, I get an occasional stall in totem on a large forward seek. It's not a complete deadlock as I can just seek to another position and it will start playing again.

Attached is a debug log that resulted in starting the video and then performing one large seek forward. The ERROR shows up at 0:00:08.74526783.
Comment 1 Dan Nicholson 2014-05-20 23:06:19 UTC 
See also bug727611.
Comment 2 Nicolas Dufresne (ndufresne) 2014-05-25 00:16:52 UTC 
Many changed has been merge (even though accidentally), but these two patch might be enough to fix this particular issue. When 727611 will be done, I'll have another path that I know fixes the rest of the race.

commit 3acbd9cb99b9cbe4c6f3b23107d22a649e8a0540
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Fri May 23 17:54:20 2014 -0400

    v4l2videodec: Handle early task stop

commit 3a7bd8d479ee069913df0762c3c98b6d3e8291d1
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Fri May 23 19:10:21 2014 -0400

    v4l2bufferpool: Prevent num_queued from going negative
Comment 3 Nicolas Dufresne (ndufresne) 2014-05-26 18:12:40 UTC 
Works for me now.

commit e2fd7e274eb5bdb3fa03c4e8254086f42cf80b0c
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Sat May 24 20:20:07 2014 -0400

    v4l2bufferpool: Port to bufferpool flush_start/stop method
    
    Port the buffer pool to use the new flush_start/flush_stop virtual
    methods added to GstBufferPool.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727611