After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730473 - rtspsrc: add support for key length parameters
rtspsrc: add support for key length parameters
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-20 22:02 UTC by Aleix Conchillo Flaqué
Modified: 2014-06-19 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add key length parameter support (2.15 KB, patch)
2014-05-20 22:02 UTC, Aleix Conchillo Flaqué
none Details | Review
add key length parameter support fixup (9.98 KB, patch)
2014-05-22 02:36 UTC, Aleix Conchillo Flaqué
none Details | Review
add key length parameter support 2nd fixup (10.06 KB, patch)
2014-05-22 18:41 UTC, Aleix Conchillo Flaqué
none Details | Review
add key length parameter support 3rd fixup (10.11 KB, patch)
2014-06-12 18:44 UTC, Aleix Conchillo Flaqué
committed Details | Review

Description Aleix Conchillo Flaqué 2014-05-20 22:02:42 UTC
Created attachment 276903 [details] [review]
add key length parameter support

This patch together with bug 730472 adds supprot for exchanging key lengths parameters.

However, it currently misses the key length for the RTCP encoder in rtspsrc, which still uses the default parameters (AES-128 and HMAC-SHA1-80) and random key.
Comment 1 Aleix Conchillo Flaqué 2014-05-22 02:36:56 UTC
Created attachment 276966 [details] [review]
add key length parameter support fixup

This new patch also adds a new signal request-rtcp-key in rtspsrc that allows the user to provide the crypto parameters and key for sending the RTCP messages.
Comment 2 Aleix Conchillo Flaqué 2014-05-22 18:41:25 UTC
Created attachment 277003 [details] [review]
add key length parameter support 2nd fixup

Same as before but added a couple of missing g_value_unset.
Comment 3 Aleix Conchillo Flaqué 2014-06-12 18:44:42 UTC
Created attachment 278363 [details] [review]
add key length parameter support 3rd fixup

This just fixes the commit log by adding reference to this bug number.
Comment 4 Wim Taymans 2014-06-19 14:18:46 UTC
commit 98a4ee0f9245124527076bfc781369ed4f3683f2
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Thu Jun 19 16:17:23 2014 +0200

    rtspsrc: pass the stream id when asking for crypto params
    
    This way the app can choose different parameters for each stream.

commit 7ce0ea3946e965e7cc9bbe43e9e69129f6d890f5
Author: Aleix Conchillo Flaqué <aleix@oblong.com>
Date:   Tue May 20 14:58:07 2014 -0700

    rtspsrc: add support for key length parameters
    
    This patch adds supports for the incoming key management parameters for
    encryption and authentication key lengths.
    
    It also adds a new signal request-rtcp-key that allows the user to
    provide the crypto parameters and key for the RTCP stream.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730473