GNOME Bugzilla – Bug 730428
Some fixes and polish for the dialogs
Last modified: 2014-08-10 07:12:53 UTC
* Remove the close button in action dialog, move the action button to the end and add a cancel button on the start, see the HIG[1] page about this * Add "suggested-action" style class where it missing * Align some string in the encoding dialog
I forgot to add the link to the HID page: [1] https://wiki.gnome.org/Design/HIG/Dialogs#Action_Dialogs
Created attachment 276829 [details] [review] cookies-dialog: Use cancel button instead of close button
Created attachment 276830 [details] [review] history-dialog: Use cancel button instead of close button
Created attachment 276831 [details] [review] passwords-dialog: Use cancel button instead of close button
Created attachment 276832 [details] [review] prefs-lang-dialog: Make the dialog to be modal
Created attachment 276833 [details] [review] prefs-lang-dialog: Add "suggested-action" style class to the add button
Created attachment 276834 [details] [review] encoding-dialog: Align a label correctly
The prefs-lang and encodings patches are clearly fine, but I think your changes to the history, cookies, and passwords dialogs are based on a misreading of the HIG. In particular, I think these dialogs are presentation dialogs (in the language of the HIG), not action dialogs. In an action dialog, the content is setup for the action button in the header bar. Action dialogs are explicit-apply: nothing happens until you click the action button. In contrast, the primary purpose of the history/cookies/passwords dialogs is to present information and allow the user to delete that information individually if he wishes: the deletion is instant apply, and clicking Cancel will not undo those deletions. In particular (emphasis added): "Action dialogs present options and information about a specific action *before it is carried out.*" "Explicit apply is only necessary if changes in the dialog have to be applied simultaneously in order to have the desired behaviour. Explicit apply dialogs include a Cancel and a Done button (Cancel resets all values in the dialog to the state before it was opened and Done applies all changes and closes the window)." "Instant apply presentation dialogs have a close button in their header bar."
Review of attachment 276833 [details] [review]: Pushed as f5406 - prefs-lang-dialog: Add "suggested-action" style class to the add button
Review of attachment 276834 [details] [review]: Pushed as 15f08 - encoding-dialog: Align a label correctly