After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730373 - addressbook: Fix some potential NULL pointer dereferences with SQL
addressbook: Fix some potential NULL pointer dereferences with SQL
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-05-19 13:26 UTC by Philip Withnall
Modified: 2014-05-20 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
addressbook: Fix some potential NULL pointer dereferences with SQL (1.97 KB, patch)
2014-05-19 13:26 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-05-19 13:26:02 UTC 
Patch attached. This one is fairly major, I think.
Comment 1 Philip Withnall 2014-05-19 13:26:04 UTC 
Created attachment 276772 [details] [review]
addressbook: Fix some potential NULL pointer dereferences with SQL

The PreflightContext.constraints field may be NULL, especially when
calling query_preflight() with a newly-initialised context from
PREFLIGHT_CONTEXT_INIT.

Coverity issues: #1214492, #1214493
Comment 2 Milan Crha 2014-05-19 16:18:22 UTC 
Review of attachment 276772 [details] [review]:

OK, feel free to commit it. Thanks.
Comment 3 Philip Withnall 2014-05-20 10:11:03 UTC 
Attachment 276772 [details] pushed as 391481b - addressbook: Fix some potential NULL pointer dereferences with SQL