After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730361 - plparse: Fix potential integer overflow when parsing long durations
plparse: Fix potential integer overflow when parsing long durations
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-19 09:50 UTC by Philip Withnall
Modified: 2014-05-19 11:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plparse: Fix potential integer overflow when parsing long durations (2.35 KB, patch)
2014-05-19 09:50 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-05-19 09:50:04 UTC 
Patch attached.
Comment 1 Philip Withnall 2014-05-19 09:50:05 UTC 
Created attachment 276748 [details] [review]
plparse: Fix potential integer overflow when parsing long durations

If a duration legitimately specifies a huge number of hours, there is
the potential for an integer overflow when converting to seconds.

Coverity issue: #60480
Comment 2 Bastien Nocera 2014-05-19 09:51:08 UTC 
Review of attachment 276748 [details] [review]:

Looks good. Want to look at the same bugs in totem?
Comment 3 Philip Withnall 2014-05-19 11:28:07 UTC 
Attachment 276748 [details] pushed as 4707e16 - plparse: Fix potential integer overflow when parsing long durations