After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730320 - Coverity caught some bugs in the code
Coverity caught some bugs in the code
Status: RESOLVED FIXED
Product: evolution-ews
Classification: Other
Component: Miscellaneous / EWS Core
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: Evolution EWS maintainer(s)
Evolution EWS maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-18 09:18 UTC by Fabiano Fidêncio
Modified: 2014-05-19 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix 'Unintialized pointer read' (1.57 KB, patch)
2014-05-18 09:19 UTC, Fabiano Fidêncio 		committed Details | Review
Fix 'Uninitialized scalar variable' (1.13 KB, patch)
2014-05-18 09:19 UTC, Fabiano Fidêncio 		committed Details | Review
Fix 'Logically dead code' (2.34 KB, patch)
2014-05-18 09:19 UTC, Fabiano Fidêncio 		none Details | Review
Fix 'Logically dead code' (3.69 KB, patch)
2014-05-18 10:40 UTC, Fabiano Fidêncio 		needs-work Details | Review
Fix 'Logically dead code' (3.36 KB, patch)
2014-05-19 09:13 UTC, Fabiano Fidêncio 		committed Details | Review

Description Fabiano Fidêncio 2014-05-18 09:18:10 UTC 
I've added the maintainers of the project in the Coverity and we can use the tool from time to time.
Comment 1 Fabiano Fidêncio 2014-05-18 09:19:39 UTC 
Created attachment 276719 [details] [review]
Fix 'Unintialized pointer read'

Catch by https://scan.coverity.com
Comment 2 Fabiano Fidêncio 2014-05-18 09:19:44 UTC 
Created attachment 276720 [details] [review]
Fix 'Uninitialized scalar variable'

Catch by https://scan.coverity.com
Comment 3 Fabiano Fidêncio 2014-05-18 09:19:49 UTC 
Created attachment 276721 [details] [review]
Fix 'Logically dead code'

Catch by https://scan.coverity.com
Comment 4 Fabiano Fidêncio 2014-05-18 10:40:24 UTC 
Created attachment 276724 [details] [review]
Fix 'Logically dead code'

Catch by https://scan.coverity.com
Comment 5 Milan Crha 2014-05-19 06:33:47 UTC 
Review of attachment 276724 [details] [review]:

Please update this one.

::: src/calendar/e-cal-backend-ews.c
@@ +2230,1 @@
 				EEwsItem *item = ids->data;

I suppose, after your change, the 'ids' will be NULL here (check when you get to this path).

@@ +2261,3 @@
 	}
 
 	if (error == NULL) {

here should be used 'local_error' instead (when you'll be in the changes here).
Comment 6 Milan Crha 2014-05-19 06:34:05 UTC 
Review of attachment 276719 [details] [review]:

This looks fine.
Comment 7 Milan Crha 2014-05-19 06:34:24 UTC 
Review of attachment 276720 [details] [review]:

This looks fine too. Thanks.
Comment 8 Fabiano Fidêncio 2014-05-19 09:13:24 UTC 
Created attachment 276745 [details] [review]
Fix 'Logically dead code'

Catch by https://scan.coverity.com
Comment 9 Milan Crha 2014-05-19 10:01:00 UTC 
Review of attachment 276745 [details] [review]:

Thanks, it looks better. I didn't test it, but looks fine. Feel free to commit it.
Comment 10 Fabiano Fidêncio 2014-05-19 11:08:35 UTC 
Okay, pushed!
Will be available on 3.13.2+ and 3.12.3+.