After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730319 - Test aliasfilecheck fails when out-of-source build is done
Test aliasfilecheck fails when out-of-source build is done
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: .General
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-18 08:12 UTC by Michał Górny
Modified: 2014-05-23 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Initial patch for the issue (1.45 KB, patch)
2014-05-18 09:01 UTC, Michał Górny
none Details | Review

Description Michał Górny 2014-05-18 08:12:35 UTC
Built fresh from gtk-2-24 git branch. When doing 'make check', the 'aliasfilescheck.sh' test fails:

FAIL: aliasfilescheck.sh
========================

grep: gtkmarshal.c: No such file or directory
grep: gtkmarshalers.c: No such file or directory
grep: gtktypebuiltins.c: No such file or directory
212d211
< __GTK_TYPE_BUILTINS_C__
228d226
< __gtk_marshal_MARSHAL_C__



The issue seems to be that the 'gtk_all_c_sources' variable contains both supplied and built sources. The test assumes all files reside in $srcdir while built sources actually land in $builddir.
Comment 1 Michał Górny 2014-05-18 09:01:06 UTC
Created attachment 276718 [details] [review]
Initial patch for the issue

It's not pretty -- I've used an outer 'for' loop with 'if' looking for files both in builddir (cwd) and srcdir. This particularly guarantees that if some of the files were supplied in $srcdir, and then were regenerated in $builddir, only the new version will be used.
Comment 2 Matthias Clasen 2014-05-23 10:40:23 UTC
tbh, I'd rather not touch it. gtk2 is in deep maintenance mode. the alias check is a tool that is only mean to work during make distcheck, which it does.