After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730316 - "Difficulty" button label is ambiguous
"Difficulty" button label is ambiguous
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-18 02:43 UTC by Michael Catanzaro
Modified: 2014-05-19 04:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Rename Difficulty button to Change Difficulty (1.02 KB, patch)
2014-05-18 02:43 UTC, Michael Catanzaro
needs-work Details | Review
Rename Difficulty button to Change Difficulty (1.46 KB, patch)
2014-05-18 16:08 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2014-05-18 02:43:02 UTC
In an earlier version of Allan's designs, we used a Change Difficulty button, but it was eventually altered to say just Difficulty.  Can we go back to Change Difficulty?  The label just feels incomplete to me.

Quote from the HIG, which I think applies here: [1]

"Do not shorten your text to the point of losing meaning. A three-word label that provides clear information is better than a one-word label that is ambiguous or vague. Try to find the fewest possible words to satisfactorily convey the meaning of your label."

[1] https://wiki.gnome.org/Design/HIG/WritingStyle
Comment 1 Michael Catanzaro 2014-05-18 02:43:23 UTC
Created attachment 276713 [details] [review]
Rename Difficulty button to Change Difficulty
Comment 2 Robert Roth 2014-05-18 09:23:09 UTC
There's a small issue with the fix you propose, because of the Change Difficulty label being much longer than the other buttons:
1. Resize the game to minimum size on the size selection screen
2. Start the game in 8x8 mode
3. Click a field to reveal it (and start the game, and make the Pause button appear)
Expected: no resizing
What happens: the board resizes.
So, the buttons-box size request and the window minimum size request has to be updated to accomodate the large button. (HINT: the built-in Gtk Inspector will be really useful to finding the appropriate values)
Comment 3 Robert Roth 2014-05-18 09:52:00 UTC
Review of attachment 276713 [details] [review]:

See my comments on the bug.
Comment 4 Michael Catanzaro 2014-05-18 16:08:14 UTC
Created attachment 276730 [details] [review]
Rename Difficulty button to Change Difficulty

Fix the resizing issue.
Comment 5 Robert Roth 2014-05-19 04:43:35 UTC
Review of attachment 276730 [details] [review]:

Thanks, committed.
Comment 6 Robert Roth 2014-05-19 04:44:55 UTC
Review of attachment 276730 [details] [review]:

Committed.
Comment 7 Robert Roth 2014-05-19 04:45:27 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.