GNOME Bugzilla – Bug 73031
Inconsistent exit dialogs
Last modified: 2006-02-18 08:59:09 UTC
Attempt to exit iagno shows Question dialog with buttons in order Yes-No. Exiting mahjongg shows Information dialog with buttons in order No-Yes. Wonder what the others would show me... :)
Should be No Yes, or maybe Cancel Quit they are inconsistent in more ways, as to when they appear: 1) some games always ask if you want to quit, 2) other games ask only if a game is running 3) never ask all should be 2), and similar question should be asked on New Game, Restart Game, New with seed, layout change in preferences (as in mahjongg, you cannot simply switch from easy to difficult, you need to restart). I.e. if no game is running, don't ask anything. If game is in progress, ask for confirmation, maybe user clicked accidentally. Playing a game is the same as editing a document. Editors ask "you have modified the document, do you want to save changes [Cancel] [Don't save] [Save]". Should this be for games Game is currently running. Do you want to end this game? [Continue Playing] [End Game]
Should be " [Cancel] [Quit]"
marking as an HIG compliance issue
Is there a reason that [Don't quit] is unsuitable in place of [Cancel]? It seems to leave a lot less room for misinterpretation
Some one is working on this, the dialogs should be [Cancel][Quit], and will only popup when you are on the middle of a game.
What's the status on this ? Can you please assign this bug to the person who's making the changes ? Thank you
Created attachment 9751 [details] [review] mahjongg fix
let's do this one game at a time.
Created attachment 9755 [details] [review] dialog patch (also fixes other iagno bug)
Created attachment 9763 [details] [review] freecell patch
Created attachment 9764 [details] [review] gataxx patch
man, I should really test these a bit better, that one for freecell contains a stray printf. I should have all of these done in the next day or so, want me to submit a huge patch?
You da man! I'd prefer smaller patches, but a huge one is fine if it replaces all previous patches. Please also create Changelog entries to describe the changes ('M-x add-change-log-entry' in the function in Emacs is your new best friend).
Created attachment 9787 [details] [review] multi game patch
That patch updates everything to "[cancel] [quit]" and to only show it if the game is in progress. For some games it always shows it because the game "automatically" starts a new game. Should we keep this open until those games have a running state variable? I suggest we close this after patch is approved/applied, then deal with checking the state after bug 87856 is closed:) Also note I am not as proficient in C++ as I am in C, so gnometris is not fixed, can someone else do a (rather trivial) patch please?
oops, reference above should be to bug 87886. Marking as high since there is a patch too.
Created attachment 9788 [details] [review] small changelog patch too
Created attachment 9789 [details] [review] aisleriot patch, not included because untested
those last three patches (9787, 9788, and 9789) should update everything but gnometris. Please test/commit:)
Created attachment 9860 [details] [review] tested aisleriot patch
*** Bug 90494 has been marked as a duplicate of this bug. ***
I *think* all of these are now in HEAD. They might wander towards the stable branch, but as they are string changes... :)