After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730266 - common: add new AG_GST_CHECK_GST_RTP
common: add new AG_GST_CHECK_GST_RTP
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: common
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-16 18:47 UTC by Aleix Conchillo Flaqué
Modified: 2014-05-22 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add new AG_GST_CHECK_GST_RTP (1.24 KB, patch)
2014-05-16 18:47 UTC, Aleix Conchillo Flaqué 		rejected Details | Review

Description Aleix Conchillo Flaqué 2014-05-16 18:47:51 UTC 
Created attachment 276683 [details] [review]
add new AG_GST_CHECK_GST_RTP

Adds a new check for the RTP library.
Comment 1 Sebastian Dröge (slomo) 2014-05-19 08:22:25 UTC 
Comment on attachment 276683 [details] [review]
add new AG_GST_CHECK_GST_RTP

While this looks ok, we don't really have *any* checks for the gst-plugins-base libraries in there. Only for the core libraries and a generic one for gst-plugins-base.

If we decide to have per-lib checks for gst-plugins-base libs in there, please let's add checks for all the libraries at once for consistency. And make use of them.
Comment 2 Aleix Conchillo Flaqué 2014-05-20 19:51:14 UTC 
(In reply to comment #1)
> (From update of attachment 276683 [details] [review])
> While this looks ok, we don't really have *any* checks for the gst-plugins-base
> libraries in there. Only for the core libraries and a generic one for
> gst-plugins-base.
> 
> If we decide to have per-lib checks for gst-plugins-base libs in there, please
> let's add checks for all the libraries at once for consistency. And make use of
> them.

I just removed the dependency on this macro in bug 730268.

May be we should close this one, it seems no body has had the need of specific macros for gst-plugins-base libraries. So, probably not worth it and I don't have a strong opinion on it.
Comment 3 Sebastian Dröge (slomo) 2014-05-22 13:42:09 UTC 
Comment on attachment 276683 [details] [review]
add new AG_GST_CHECK_GST_RTP

Let's do that then :)