After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730207 - v4l2: Seeking with M2M devices
v4l2: Seeking with M2M devices
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-15 16:18 UTC by Nicolas Dufresne (ndufresne)
Modified: 2014-05-15 16:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nicolas Dufresne (ndufresne) 2014-05-15 16:18:18 UTC
The following patch, even though correct, introduced regression in seeking that leads to stall.

commit 6f5edb3b4b684fa2a9bf8f14d7d9fd49f54f62eb
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Tue Apr 29 14:56:31 2014 -0400

    v4l2transform: Handle FLUSH_STOP event
Comment 1 Nicolas Dufresne (ndufresne) 2014-05-15 16:23:36 UTC
The following patchset address the issue. Even though not perfect (see bug #727611) it makes seeking work again for mmap pools and also fixes the dmabuf-import and userptr cases. This include few, but seperate cosmetic changes.


commit 541a9670d23c89f69f5c272c5c2fa37edf6d8f1c
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Thu May 15 10:44:29 2014 -0400

    v4l2videodec: Handle start_streaming error
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207

commit bff156bc57e7e367697f545ffcf08791880bd04c
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Thu May 15 10:39:40 2014 -0400

    v4l2videodec: Print the flow return causing the loop to leave
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207

commit f384047be390ebb8a940a0361e59ce75af5d5934
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Thu May 15 10:31:40 2014 -0400

    v4l2videodec: Don't lock the decoder when stopping task
    
    That src pad task may need to take the lock when being pulled
    down. takeing that lock can lead to a deadlock.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207

commit 5f10d2b4e2c23b678d00c1185d4e68b9c0c3ea75
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Wed May 14 17:18:52 2014 -0400

    v4l2transform: Don't leak pool if activation failed
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207

commit a4b5811d22ba401fbcfc4d264034a9ca1d9aca67
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Wed May 14 17:18:35 2014 -0400

    v4l2: Split flush in start/stop_streaming
    
    This allow calling start streaming later for capture device. Currently it breaks
    in dmabuf-import because downstream is holding a buffer that will only be
    released after stream-start.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207

commit c1792de95e9a6b28891a53cd953941d30bebf09d
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Wed May 14 15:12:26 2014 -0400

    v4l2transform: Flush buffer pools on flush stop
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207

commit 7986c55dcb6095a3bc379f17472374eeefc350b6
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Wed May 14 13:28:31 2014 -0400

    v4l2allocator: Fix use of atomic active marker
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207

commit 19608ac85b13c7ce41d303fc2e3d3b6914489106
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Wed May 14 13:05:42 2014 -0400

    v4l2bufferpool: Don't deactivate otherpool
    
    We should not stop the otherpool unless we also stop our own
    pool, otherwise it will never get restarted.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207

commit 4b2808c31036ef22410b87fb10274a694ca9d554
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Wed May 14 12:33:58 2014 -0400

    v4l2bufferpool: Also update num_buffers for import cases
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730207