After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730181 - failed to parse '%' character in gst_structure_from_string
failed to parse '%' character in gst_structure_from_string
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-15 10:50 UTC by Justin Kim
Modified: 2018-11-03 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add '%' character in GST_ASCII_IS_STRING macro (1.03 KB, patch)
2014-05-15 12:17 UTC, Wonchul Lee
reviewed Details | Review

Description Justin Kim 2014-05-15 10:50:20 UTC
gst_structure_from_string seems not to accept '%' character due to missing define in ASCII_IS_STRING in gst_private.h

Is that omitted on purpose? 

154 /* used in gstvalue.c and gststructure.c */
155 #define GST_ASCII_IS_STRING(c) (g_ascii_isalnum((c)) || ((c) == '_') || \
156     ((c) == '-') || ((c) == '+') || ((c) == '/') || ((c) == ':') || \
157     ((c) == '.'))
Comment 1 Wonchul Lee 2014-05-15 12:17:21 UTC
Created attachment 276601 [details] [review]
Add '%' character in GST_ASCII_IS_STRING macro

I add '%' character in GST_ASCII_IS_STRING for the escaped character and it works well.
Comment 2 Sebastian Dröge (slomo) 2014-05-19 09:05:02 UTC
FWIW, it works if you escape the % with a backslash \

It's probably ommitted on purpose, but I'm not aware of any special meaning of the % character. So it can probably be changed safely if there's a good reason to do so.

What are you using the % for though?
Comment 3 Justin Kim 2014-05-19 13:25:19 UTC
> What are you using the % for though? 

I just found this error when I used html_escaped characters for value, and no more.
e.g. a blank character (space) is converted into %20.

I think it would be better to support '%' if it has no special purpose :)
Comment 4 Edward Hervey 2018-05-04 08:49:31 UTC
I think this is still valid for the urlencoded strings use-case.
Comment 5 GStreamer system administrator 2018-11-03 12:20:35 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/57.