GNOME Bugzilla – Bug 730130
Fortran Language file: Add support for OpenMP directives
Last modified: 2014-05-16 17:12:44 UTC
Created attachment 276535 [details] [review] Patch introducing OpenMP directives for Fortran OpenMP directives are preceded by `!$` or `^[Cc]$`. They either contain compiler directives like !$omp parallel do do i=1,100 a(i) = i*i enddo !$omp end parallel do or Fortran statements that are executed when OpenMP is enabled in the compiler: !$ use omp_lib !$ real*8 :: t1 !$ t1 = omp_get_wtime() If OpenMP is disabled, these directives are treated as regular comments. The attached patch treats lines starting with `!$` or `^[Cc]$` as preprocessor directives for coloring.
Also, see this SO issue: https://stackoverflow.com/questions/23081274/openmp-syntax-highlighting-in-gedit
Review of attachment 276535 [details] [review]: The patch looks good. It would be nice to add an example in tests/testfiles.sh. And it's easier for us if you create the patch with the "git format-patch" command, so we have a commit message and the author.
Created attachment 276604 [details] [review] Updated patch
Is that better?
Comment on attachment 276604 [details] [review] Updated patch I've pushed the commit with small fixes: - the commit message, it must be one short line, followed by a blank line and then the long description (see the HACKING file for more details). - remove trailing spaces Also, when you update a patch, mark the old one as obsolete.