After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730080 - Impossible to add non-web type accounts (OwnCloud, Exchange, Jabber...) in 3.13.1 - cannot complete dialogs
Impossible to add non-web type accounts (OwnCloud, Exchange, Jabber...) in 3....
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
git master
Other Linux
: Normal blocker
: ---
Assigned To: GNOME Online Accounts maintainer(s)
Control-Center Maintainers
Depends on:
Blocks: 729638
 
 
Reported: 2014-05-13 19:43 UTC by Adam Williamson
Modified: 2014-05-22 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot of an example problematic dialog (6.75 KB, image/png)
2014-05-13 19:43 UTC, Adam Williamson 		  Details
online-accounts: Use a header bar for the "Add Account" dialog (3.20 KB, patch)
2014-05-21 09:36 UTC, Debarshi Ray 		committed Details | Review

Description Adam Williamson 2014-05-13 19:43:33 UTC 
Created attachment 276474 [details]
screenshot of an example problematic dialog

Via the Control Center 'Online Accounts' panel, in control-center 3.13.1, it seems impossible to add any kind of 'non-web' type account - that is, account types that don't use some kind of web UI for authentication, e.g. OwnCloud, Exchange, and Jabber. There is no OK button, or indeed any button of any kind, in the dialog that pops up for such accounts. You can fill in all your account details, but there seems to be no way to complete the dialog - even tab tricks to try and find a 'hidden' button don't seem to work, nor does hitting Enter. All you can do is hit Esc to cancel back out.

Screenshot attached.

To reproduce: open Control Center, go to Online Accounts, click +, select the OwnCloud account type, note there is no apparent way to complete the dialog.
Comment 1 Adam Williamson 2014-05-13 19:45:08 UTC 
running current Fedora Rawhide, control-center-3.13.1-4.fc21.x86_64 , gnome-online-accounts-3.13.1-1.fc21.x86_64 .
Comment 2 Debarshi Ray 2014-05-20 13:16:08 UTC 
This is a fallout from this gtk+ commit:

commit 7e479aa9eeff38d358d20b155a55a07ab04ba1e9
Author: William Jon McCann <william.jon.mccann@gmail.com>
Date:   Wed Apr 9 14:30:37 2014 -0400

    dialog: add a box around the action area to use for styling
    
    If we want to set style properties that include the area
    of the border-width part of action_area we need to use a
    parent box.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722211

As a result of that the widget returned by gtk_dialog_get_action_area is not a part of gtk_container_get_children, which breaks the logic in add_account_dialog_add_account in panels/online-accounts/cc-online-accounts-add-account-dialog.c
Comment 3 Debarshi Ray 2014-05-21 09:35:29 UTC 
I think that instead of trying to actually fix this, we should just switch over to using header bars in this dialog.
Comment 4 Debarshi Ray 2014-05-21 09:36:02 UTC 
Created attachment 276921 [details] [review]
online-accounts: Use a header bar for the "Add Account" dialog
Comment 5 Bastien Nocera 2014-05-21 09:42:03 UTC 
Review of attachment 276921 [details] [review]:

Looks fine
Comment 6 Debarshi Ray 2014-05-21 16:08:12 UTC 
Comment on attachment 276921 [details] [review]
online-accounts: Use a header bar for the "Add Account" dialog

Thanks for the review, Bastien.
Comment 7 Adam Williamson 2014-05-22 22:32:22 UTC 
Fix confirmed (and backported to Rawhide, just cos I'm that nice :P). thanks!