After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730065 - .gitignore/.cvsignore cleanups
.gitignore/.cvsignore cleanups
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-13 14:32 UTC by Christophe Fergeau
Modified: 2014-12-10 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove obsolete files (5.79 KB, patch)
2014-05-13 14:32 UTC, Christophe Fergeau 		accepted-commit_now Details | Review
Add .gitignore file (1.32 KB, patch)
2014-05-13 14:32 UTC, Christophe Fergeau 		reviewed Details | Review
Remove obsolete files (6.29 KB, patch)
2014-05-14 11:37 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2014-05-13 14:32:05 UTC 
This removes some obsolete files from the source tree
Comment 1 Christophe Fergeau 2014-05-13 14:32:09 UTC 
Created attachment 276456 [details] [review]
Remove obsolete files

libsj.h is not used anywhere, and .cvsignore files are not used by git,
and these files are out of date if renamed to .gitignore.
Comment 2 Christophe Fergeau 2014-05-13 14:32:15 UTC 
Created attachment 276457 [details] [review]
Add .gitignore file
Comment 3 Phillip Wood 2014-05-14 10:17:16 UTC 
Review of attachment 276456 [details] [review]:

Makes sense, what about .bzrignore?
Comment 4 Phillip Wood 2014-05-14 10:20:27 UTC 
Review of attachment 276457 [details] [review]:

Currently .gitignore get generated by make with git.mk. We could add some more patterns to GITIGNOREFILES if there are more files to ignore
Comment 5 Christophe Fergeau 2014-05-14 11:37:06 UTC 
Created attachment 276522 [details] [review]
Remove obsolete files

libsj.h is not used anywhere, and .cvsignore files are not used by git,
and these files are out of date if renamed to .gitignore.
Comment 6 Christophe Fergeau 2014-05-14 13:06:35 UTC 
Review of attachment 276457 [details] [review]:

Ah right, missed that as the help files do not get added to .gitignore for some reason.
Comment 7 Phillip Wood 2014-05-14 15:08:20 UTC 
Review of attachment 276522 [details] [review]:

Looks good
Comment 8 Phillip Wood 2014-12-10 11:15:04 UTC 
Attachment 276522 [details] pushed as d178f1c - Remove obsolete files
Attachment 276457 [details] is obsoleted by attachment 292358 [details] [review] - Update git.mk on bug 741288