After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729970 - gtk-demo.py: Replace direct parent class call by super()
gtk-demo.py: Replace direct parent class call by super()
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-11 20:12 UTC by Andrew Grigorev
Modified: 2014-05-11 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Replace direct parent class call by super() (1.42 KB, patch)
2014-05-11 20:13 UTC, Andrew Grigorev
committed Details | Review

Description Andrew Grigorev 2014-05-11 20:12:59 UTC
There is a comment in source code, from which we can suppose that author was
in a doubt about why super() call is not working. But there is a parent class
specified in that call in comment, not the class which defines the current
__init__, as the super() requires.

So, the super() call works, it just needs the correct class.
Comment 1 Andrew Grigorev 2014-05-11 20:13:01 UTC
Created attachment 276345 [details] [review]
Replace direct parent class call by super()

Super works, it just needs the correct class.
Comment 2 Simon Feltman 2014-05-11 21:26:19 UTC
Looks good, thanks!

Attachment 276345 [details] pushed as bc7b0b6 - Replace direct parent class call by super()