After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729962 - Use a header bar in the preferences dialog
Use a header bar in the preferences dialog
Status: RESOLVED FIXED
Product: gnome-nibbles
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-nibbles-maint
gnome-nibbles-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-11 16:45 UTC by Michael Catanzaro
Modified: 2014-05-12 15:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require GTK+ 3.12 (780 bytes, patch)
2014-05-11 16:45 UTC, Michael Catanzaro 		committed Details | Review
Use a header bar on the preferences dialog (1.26 KB, patch)
2014-05-11 16:45 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-05-11 16:45:47 UTC 
The functional difference is that the close button is now an X in the header bar (which can be styled and positioned by the desktop environment), rather than a separate button tacked on to the bottom of the dialog.
Comment 1 Michael Catanzaro 2014-05-11 16:45:49 UTC 
Created attachment 276337 [details] [review]
Require GTK+ 3.12

For GTK_DIALOG_USE_HEADER_BAR
Comment 2 Michael Catanzaro 2014-05-11 16:45:52 UTC 
Created attachment 276338 [details] [review]
Use a header bar on the preferences dialog
Comment 3 Michael Catanzaro 2014-05-11 16:47:19 UTC 
(This was supposed to be done prior GNOME 3.12, to match the core applications.  I missed the memo.)
Comment 4 gQuigs 2014-05-12 03:38:19 UTC 
This looks fine.. Is it supposed to land in 3.12 or master?
Comment 5 Michael Catanzaro 2014-05-12 15:20:52 UTC 
I'm only going to push it to master. It's a minor change, but I think it would be a UI freeze break.

Attachment 276337 [details] pushed as 726fd2e - Require GTK+ 3.12
Attachment 276338 [details] pushed as 0f93767 - Use a header bar on the preferences dialog