After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729949 - core plugins and libgstbase now depend on gio
core plugins and libgstbase now depend on gio
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal blocker
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-11 10:49 UTC by Tim-Philipp Müller
Modified: 2014-05-13 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tim-Philipp Müller 2014-05-11 10:49:56 UTC
Through GstSparseFile and the new downloadbuffer element the core plugins and libgstbase seem to now have acquired a dependency on libgio, through use of the gio error enums and g_io_error_from_errno().

This seems undesirable and unnecessary. gio is quite a heavy dependency, it would be good not to make it a dependency of core libraries unless it's really needed.
Comment 1 Sebastian Dröge (slomo) 2014-05-11 13:00:41 UTC
Definitely! GIO is huge and we should only use it when really required.
Comment 2 Tim-Philipp Müller 2014-05-13 19:16:35 UTC
commit f28a4cc671f161db2698a7e17a8e7b662dbf6d33
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Tue May 13 19:51:34 2014 +0100

    elements: don't depend on libgio just for g_io_error_from_errno()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729949

commit fa94322349808e6c4fac1e48204fd5602f4e99e3
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Tue May 13 19:30:38 2014 +0100

    sparsefile: keep it private as helper API for downloadbuffer
    
    There's no expectation that any other element or applications
    might want to use this helper API any time soon, so keep it
    private for the time being. There were open questions regarding
    portability and binding-friendliness too.
    
    This also removes the gio dependency of -base again.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729951
    https://bugzilla.gnome.org/show_bug.cgi?id=729949