After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729892 - g_app_info_remove_supports_type needs better API documentation
g_app_info_remove_supports_type needs better API documentation
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gio
2.40.x
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-05-09 18:33 UTC by Kip
Modified: 2018-05-24 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add better API documentation for GIO's g_app_info_remove_supports_type() (1.59 KB, patch)
2014-05-09 18:39 UTC, Kip 		none Details | Review

Description Kip 2014-05-09 18:33:51 UTC 
The g_app_info_remove_supports_type() desktop entry function located in gio/gappinfo.c could use better API documentation. 

Right now without my attached patch, it wasn't clear that the first parameter 'GAppInfo *appinfo' was not required. 

According to the source, it can actually be NULL. In order to remove a MIME entry from both of the 'Added Associations' and 'Default Applications' keys in the user's mimeapps.list, instead of only the former, this parameter actually must be NULL and is the only way to do it from what I could see in following the code paths.
Comment 1 Kip 2014-05-09 18:39:17 UTC 
Created attachment 276259 [details] [review]
Patch to add better API documentation for GIO's g_app_info_remove_supports_type()
Comment 2 Kip 2014-05-12 18:48:57 UTC 
Ok, I don't know what I was thinking, but I just realized that setting it to NULL is not going to work, but really just if we could set the desktop_id field within it only. But I don't know if there is a safe way to do that.
Comment 3 GNOME Infrastructure Team 2018-05-24 16:30:56 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/871.