After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729886 - workspace: Don't allow closing windows with attached modals
workspace: Don't allow closing windows with attached modals
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-09 16:41 UTC by Florian Müllner
Modified: 2014-05-28 20:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspace: Don't allow closing windows with attached modals (1.36 KB, patch)
2014-05-09 16:41 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-05-09 16:41:43 UTC 
See patch.
Comment 1 Florian Müllner 2014-05-09 16:41:46 UTC 
Created attachment 276254 [details] [review]
workspace: Don't allow closing windows with attached modals

Modal dialogs prevent the parent from being closed in "normal mode",
so it makes sense to not allow it in the overview either.
Comment 2 drago01 2014-05-09 21:57:12 UTC 
Review of attachment 276254 [details] [review]:

::: js/ui/workspace.js
@@ +202,3 @@
 
+    hasAttachedDialogs: function() {
+        return this.actor.get_n_children() > 1;

Don't we have a better way to check for that? (I can't think of any non ugly one) so seems fine.
Comment 3 Florian Müllner 2014-05-28 20:05:40 UTC 
Attachment 276254 [details] pushed as 3ff4277 - workspace: Don't allow closing windows with attached modals